[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Move GLX detection from kwinglobals to
From: "Commit Hook" <null () kde ! org>
Date: 2011-07-27 16:38:51
Message-ID: 20110727163851.21031.6286 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102002/#review5133
-----------------------------------------------------------
This review has been submitted with commit 8dace03b4e84fdd0c31c60b81baf3395=
7697de18 by Martin Gr=C3=A4=C3=9Flin to branch master.
- Commit
On July 18, 2011, 7:26 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102002/
> -----------------------------------------------------------
> =
> (Updated July 18, 2011, 7:26 p.m.)
> =
> =
> Review request for kwin.
> =
> =
> Summary
> -------
> =
> Removes the Extension::glxAvailable() from kwinglobals and implements the=
functionality in CompositingPrefs, where it is only needed. There used to =
be one additional check in scene_opengl_glx.cpp which I moved into composit=
e.cpp before the OpenGL Scene is created.
> =
> Motivation for this change is that it allows us to build kwineffects with=
out an OpenGL dependency.
> =
> While looking at the detect code I think it is overall flawed as it check=
s whether there is a possible combination of extensions which would allow c=
ompositing but not checking for the selected backend (it's awesome that XRe=
nder works when OpenGL is selected and I get no compositing). I think that =
code part should be rethought.
> =
> =
> Diffs
> -----
> =
> kwin/composite.cpp fe76957 =
> kwin/compositingprefs.h 4cfc009 =
> kwin/compositingprefs.cpp 025048e =
> kwin/libkwineffects/kwinglobals.h 2a4ea71 =
> kwin/libkwineffects/kwinglobals.cpp d126a7c =
> kwin/scene_opengl_glx.cpp f935826 =
> =
> Diff: http://git.reviewboard.kde.org/r/102002/diff
> =
> =
> Testing
> -------
> =
> kwin and kwin_gles both work. I did not try to destroy my glx, so I did n=
ot test that case ;-)
> =
> =
> Thanks,
> =
> Martin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102002/">http://git.reviewboard.kde.org/r/102002/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 8dace03b4e84fdd0c31c60b81baf33957697de18 by Martin Gräßlin to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On July 18th, 2011, 7:26 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated July 18, 2011, 7:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removes the Extension::glxAvailable() from kwinglobals and implements \
the functionality in CompositingPrefs, where it is only needed. There used to be one \
additional check in scene_opengl_glx.cpp which I moved into composite.cpp before the \
OpenGL Scene is created.
Motivation for this change is that it allows us to build kwineffects without an \
OpenGL dependency.
While looking at the detect code I think it is overall flawed as it checks whether \
there is a possible combination of extensions which would allow compositing but not \
checking for the selected backend (it's awesome that XRender works when OpenGL is \
selected and I get no compositing). I think that code part should be rethought.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kwin and kwin_gles both work. I did not try to destroy my glx, so I did \
not test that case ;-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.cpp <span style="color: grey">(fe76957)</span></li>
<li>kwin/compositingprefs.h <span style="color: grey">(4cfc009)</span></li>
<li>kwin/compositingprefs.cpp <span style="color: grey">(025048e)</span></li>
<li>kwin/libkwineffects/kwinglobals.h <span style="color: \
grey">(2a4ea71)</span></li>
<li>kwin/libkwineffects/kwinglobals.cpp <span style="color: \
grey">(d126a7c)</span></li>
<li>kwin/scene_opengl_glx.cpp <span style="color: grey">(f935826)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102002/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic