'Re: Review Request: Hide the GLTexture implementation using dpointers.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Hide the GLTexture implementation using dpointers.
From:       "Philipp Knechtges" <philipp-dev () knechtges ! com>
Date:       2011-07-25 20:49:37
Message-ID: 20110725204937.4451.17644 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101999/
-----------------------------------------------------------

(Updated July 25, 2011, 8:49 p.m.)

Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Fredrik H=C3=B6glund.

Changes
-------

add the missing file, sry :)

Summary
-------

kwin: Implement "use by value" and implicit sharing for GLTexture.

Addiotionally:
- hide the GLTexture implementation using dpointers
- drop the unused function SceneOpenGL::Texture::optimizeBindDamage()
- Texture::load now loades a new texture and does not update the existing o=
ne

Diffs (updated)
-----

  kwin/libkwineffects/kwingltexture.h eaa9b768012dc1f0385b80340732bdb9fcf97=
36a =

  kwin/libkwineffects/kwingltexture.cpp 9c812876df563163b85086d47b22d1820b1=
7e79e =

  kwin/libkwineffects/kwingltexture_p.h PRE-CREATION =

  kwin/libkwineffects/kwinglutils.cpp f8a6058eb838859406dce3988eacfcb5e9f8b=
16c =

  kwin/scene_opengl.h 85b2563567fafa5b7f3ea55cf68c01482e77b08f =

  kwin/scene_opengl.cpp 0980229bb9a850258ac1b5a2c8c81f80993e45d1 =

  kwin/scene_opengl_egl.cpp 8b1b51225c94cb560d249ad7fd359bba33da2f4a =

  kwin/scene_opengl_glx.cpp f9358267e2f24b535b3a5994d44f886c3052d888 =

Diff: http://git.reviewboard.kde.org/r/101999/diff

Testing
-------

GLX tested

@Martin: i hope the EGL part works :D

Thanks,

Philipp

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101999/">http://git.reviewboard.kde.org/r/101999/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Martin Gräßlin and Fredrik Höglund.</div>
<div>By Philipp Knechtges.</div>

<p style="color: grey;"><i>Updated July 25, 2011, 8:49 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">add the missing file, sry :)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kwin: Implement &quot;use by value&quot; and implicit sharing for \
GLTexture.

Addiotionally:
- hide the GLTexture implementation using dpointers
- drop the unused function SceneOpenGL::Texture::optimizeBindDamage()
- Texture::load now loades a new texture and does not update the existing one</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">GLX tested

@Martin: i hope the EGL part works :D</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/libkwineffects/kwingltexture.h <span style="color: \
grey">(eaa9b768012dc1f0385b80340732bdb9fcf9736a)</span></li>

 <li>kwin/libkwineffects/kwingltexture.cpp <span style="color: \
grey">(9c812876df563163b85086d47b22d1820b17e79e)</span></li>

 <li>kwin/libkwineffects/kwingltexture_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/libkwineffects/kwinglutils.cpp <span style="color: \
grey">(f8a6058eb838859406dce3988eacfcb5e9f8b16c)</span></li>

 <li>kwin/scene_opengl.h <span style="color: \
grey">(85b2563567fafa5b7f3ea55cf68c01482e77b08f)</span></li>

 <li>kwin/scene_opengl.cpp <span style="color: \
grey">(0980229bb9a850258ac1b5a2c8c81f80993e45d1)</span></li>

 <li>kwin/scene_opengl_egl.cpp <span style="color: \
grey">(8b1b51225c94cb560d249ad7fd359bba33da2f4a)</span></li>

 <li>kwin/scene_opengl_glx.cpp <span style="color: \
grey">(f9358267e2f24b535b3a5994d44f886c3052d888)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101999/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 