'Re: Review Request: Enhanced Login Effect'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Enhanced Login Effect
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2011-07-24 20:09:01
Message-ID: 20110724200901.1590.14422 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101812/
-----------------------------------------------------------

(Updated July 24, 2011, 8:09 p.m.)

Review request for kwin.

Changes
-------

Re-upload of diff, did not show login_config.desktop properly. Now it does :)

Summary
-------

I always found that fade to black on a common operating system (:P) so nice, so I \
played around with the login effect, looked at the dim effect and combined parts. \
This effect basically fades the screen to black and then to the desktop instead of a \
long animation to the desktop. It looks quicker. And doesn't it look noble? :)

Video here: http://www.youtube.com/watch?v=5dsXomSlL_g

I talked with Nuno about it (he doesn't have a Review Board account?) and he liked it \
but was in fear that it might let people think the computer crashed or something if \
it hangs at the black point (or so?). There needs to be some discussion about that on \
IRC?

This patch adds another effect instead of replacing the old one but disables the Auto \
enabled from the old effect. Both effects can be enabled simultaniously without \
graphical glitches or flickering but naturally it won't fade to black completely \
because the other effect reduces the opacity already while the new one leaves it \
opaque until it is black and then fades it out.

(And I do not how translating .desktop files works and who adds them and so, so I \
just added the German translation to the file as well)

Diffs (updated)
-----

  kwin/effects/login/login_config.ui PRE-CREATION 
  kwin/effects/login/login_config.cpp PRE-CREATION 
  kwin/effects/login/login_config.desktop PRE-CREATION 
  kwin/effects/login/login_config.h PRE-CREATION 
  kwin/effects/login/login.h b1735a3 
  kwin/effects/configs_builtins.cpp b37ba58 
  kwin/effects/login/CMakeLists.txt a7cbbf3 
  kwin/effects/login/login.cpp e1d934e 
  kwin/effects/login/login.desktop 1a2cb47 

Diff: http://git.reviewboard.kde.org/r/101812/diff

Testing
-------

Compiles, works … and looks nice ;)

Thanks,

Kai Uwe

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101812/">http://git.reviewboard.kde.org/r/101812/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated July 24, 2011, 8:09 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Re-upload of diff, did not show login_config.desktop properly. Now it \
does :)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I always found that fade to black on a common operating system (:P) so \
nice, so I played around with the login effect, looked at the dim effect and combined \
parts. This effect basically fades the screen to black and then to the desktop \
instead of a long animation to the desktop. It looks quicker. And doesn't it look \
noble? :)

Video here: http://www.youtube.com/watch?v=5dsXomSlL_g

I talked with Nuno about it (he doesn't have a Review Board account?) and he liked it \
but was in fear that it might let people think the computer crashed or something if \
it hangs at the black point (or so?). There needs to be some discussion about that on \
IRC?

This patch adds another effect instead of replacing the old one but disables the Auto \
enabled from the old effect. Both effects can be enabled simultaniously without \
graphical glitches or flickering but naturally it won't fade to black completely \
because the other effect reduces the opacity already while the new one leaves it \
opaque until it is black and then fades it out.

(And I do not how translating .desktop files works and who adds them and so, so I \
just added the German translation to the file as well)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles, works … and looks nice ;)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/login/login_config.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/effects/login/login_config.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/effects/login/login_config.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/effects/login/login_config.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/effects/login/login.h <span style="color: grey">(b1735a3)</span></li>

 <li>kwin/effects/configs_builtins.cpp <span style="color: \
grey">(b37ba58)</span></li>

 <li>kwin/effects/login/CMakeLists.txt <span style="color: \
grey">(a7cbbf3)</span></li>

 <li>kwin/effects/login/login.cpp <span style="color: grey">(e1d934e)</span></li>

 <li>kwin/effects/login/login.desktop <span style="color: grey">(1a2cb47)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101812/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 