[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Implement scaled XRender shadows,
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2011-07-17 18:12:22
Message-ID: 20110717181222.29745.18731 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101975/#review4772
-----------------------------------------------------------
As it's a little bit late in the cycle I would prefer 4.7.1
- Martin
On July 17, 2011, 12:06 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101975/
> -----------------------------------------------------------
>
> (Updated July 17, 2011, 12:06 p.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Summary
> -------
>
> Yes, i know - it's f*** late in release ;-)
>
> - The scaled XRender shadows were not implemented so far, also
> - with the decorationRect() extended to the boundingRect() of the shadow region, \
> the mapping in the indirect rendering case was broken (deco sets off to the top \
> left by shadowRegion, deco widget offset)
> The patch fixes both, i'll now have a look at the OpenGL situation (the shadows are \
> positioned correctly but look broken due to stretching i assume. That may be an \
> nvidia issue, though. They sometimes look wrong in the regular case as well)
> Also i cleaned up the code a bit (moved deco preparations out of the clipper loop, \
> introduced 2 more macros and merged several "off by one variable" statements. Last \
> thing was to replace the "QPixmap::scale()" with "PA_Repeat = True" in \
> buildQuads().
> Therefore i'd like to have this in the 4.7 branch, if for 4.7.1 in doubt.
>
> There's still a minor glitch (div offset -> occasionally a gap between the top and \
> mid rects when scaling) but that's no regression over the current situation, i'll \
> try to fix that as well.
>
> Diffs
> -----
>
> kwin/scene_xrender.h b00a454
> kwin/scene_xrender.cpp d01c9c4
>
> Diff: http://git.reviewboard.kde.org/r/101975/diff
>
>
> Testing
> -------
>
> scaled alot
>
>
> Thanks,
>
> Thomas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101975/">http://git.reviewboard.kde.org/r/101975/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As it's a little bit \
late in the cycle I would prefer 4.7.1</pre> <br />
<p>- Martin</p>
<br />
<p>On July 17th, 2011, 12:06 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated July 17, 2011, 12:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, i know - it's f*** late in release ;-)
- The scaled XRender shadows were not implemented so far, also
- with the decorationRect() extended to the boundingRect() of the shadow region, the \
mapping in the indirect rendering case was broken (deco sets off to the top left by \
shadowRegion, deco widget offset)
The patch fixes both, i'll now have a look at the OpenGL situation (the shadows \
are positioned correctly but look broken due to stretching i assume. That may be an \
nvidia issue, though. They sometimes look wrong in the regular case as well)
Also i cleaned up the code a bit (moved deco preparations out of the clipper loop, \
introduced 2 more macros and merged several "off by one variable" \
statements. Last thing was to replace the "QPixmap::scale()" with \
"PA_Repeat = True" in buildQuads().
Therefore i'd like to have this in the 4.7 branch, if for 4.7.1 in doubt.
There's still a minor glitch (div offset -> occasionally a gap between the top \
and mid rects when scaling) but that's no regression over the current situation, \
i'll try to fix that as well.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">scaled alot</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/scene_xrender.h <span style="color: grey">(b00a454)</span></li>
<li>kwin/scene_xrender.cpp <span style="color: grey">(d01c9c4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101975/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic