'Review Request: Optimizing Blur Part II'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Optimizing Blur Part II
From:       "Philipp Knechtges" <philipp-dev () knechtges ! com>
Date:       2011-07-17 16:23:49
Message-ID: 20110717162349.22523.83673 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101977/
-----------------------------------------------------------

Review request for kwin, Martin Gr=C3=A4=C3=9Flin and Fredrik H=C3=B6glund.

Summary
-------

This patch adds an optional texture cache to the blur effect. The texture c=
ache allows one to partially repaint the blurred region
if the region or a window on top it is damaged. This patch does not change =
anything on the behavior of the blur effect if caching is turned off.

Some facts about the texture cache:
- It does not a full cache of the window's background. To achieve this one =
would have to shrink the clip of all following windows which results in les=
s performance.
- We only cache the horizontally blurred texture. I didnt test whether it i=
s better to cache the full result.
- For every window we have to keep a texture of the size of the blurred are=
a in the GFX memory.

Although we so far only cache all windows or none the prePaintWindow functi=
on is designed to add the possibility to decide on a per-window basis which=
 window
should be cached. But IMO this is not worth the effort cause the extra memu=
sage isnt that high.
 =

Diffs
-----

  kwin/effects/blur/blur.h 3c0922b =

  kwin/effects/blur/blur.cpp 83012b1 =

  kwin/effects/blur/blur_config.cpp 0612599 =

  kwin/effects/blur/blur_config.ui 3b99afd =

  kwin/effects/blur/blurshader.h 4308be9 =

  kwin/effects/blur/blurshader.cpp e7e5bf3 =

  kwin/libkwineffects/kwinglutils.h 0c86212 =

  kwin/libkwineffects/kwinglutils.cpp f8a6058 =

Diff: http://git.reviewboard.kde.org/r/101977/diff

Testing
-------

Thanks,

Philipp

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101977/">http://git.reviewboard.kde.org/r/101977/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Martin Gräßlin and Fredrik Höglund.</div>
<div>By Philipp Knechtges.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds an optional texture cache to the blur effect. The \
texture cache allows one to partially repaint the blurred region if the region or a \
window on top it is damaged. This patch does not change anything on the behavior of \
the blur effect if caching is turned off.

Some facts about the texture cache:
- It does not a full cache of the window&#39;s background. To achieve this one would \
                have to shrink the clip of all following windows which results in \
                less performance.
- We only cache the horizontally blurred texture. I didnt test whether it is better \
                to cache the full result.
- For every window we have to keep a texture of the size of the blurred area in the \
GFX memory.

Although we so far only cache all windows or none the prePaintWindow function is \
designed to add the possibility to decide on a per-window basis which window should \
be cached. But IMO this is not worth the effort cause the extra memusage isnt that \
high.  </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/blur/blur.h <span style="color: grey">(3c0922b)</span></li>

 <li>kwin/effects/blur/blur.cpp <span style="color: grey">(83012b1)</span></li>

 <li>kwin/effects/blur/blur_config.cpp <span style="color: \
grey">(0612599)</span></li>

 <li>kwin/effects/blur/blur_config.ui <span style="color: grey">(3b99afd)</span></li>

 <li>kwin/effects/blur/blurshader.h <span style="color: grey">(4308be9)</span></li>

 <li>kwin/effects/blur/blurshader.cpp <span style="color: grey">(e7e5bf3)</span></li>

 <li>kwin/libkwineffects/kwinglutils.h <span style="color: \
grey">(0c86212)</span></li>

 <li>kwin/libkwineffects/kwinglutils.cpp <span style="color: \
grey">(f8a6058)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101977/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 