[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Re: Review Request: DamageNotify handling
From:       Martin =?ISO-8859-1?Q?Gr=E4=DFlin?= <mgraesslin () kde ! org>
Date:       2011-07-10 15:59:44
Message-ID: 1779367.FixQP0BcSc () martin-desktop
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 10 July 2011 17:38:10 Thomas Lübking wrote:
> Am Sun, 10 Jul 2011 13:41:20 +0200
> schrieb Martin Gräßlin <mgraesslin@kde.org>:
> 
> > On Sunday 10 July 2011 13:37:35 you wrote:
> > > Am Sun, 10 Jul 2011 08:52:54 -0000
> > > schrieb Martin Gräßlin <kde@martin-graesslin.com>:
> > > 
> > > 
> > > > Could it be that this change is causing the screen to be black
> > > > when starting kwin till you have the first repaint? It's just
> > > > that I see this behavior since I recompiled today.
> > > 
> > > damageRatio isn't initialized, so yes "could" (if it was implicitly
> > > 1.0" or maybe is hanging over between suspend/resume)
> > > 
> > > Please try the attached patch (just adds initialisation & copies
> > > damageRatio to deleted windows)
> > no, it doesn't work :-( Still a black screen after restarting with
> > the patch applied
> 
> Not here, not even w/ blur enabled....
> 
> - I assume you've bisected the commit? ;-)
*cough* no, it was a wild guess as it was working yesterday on vanilla master
> - Do you test on vanilla master?
yes
> - Does it happen with the XRender backend?
not yet tested
> - Does the very first repaint clear the entire screen or only the
>   repainted area?
entire screen
> 
> The only thing i could imagine is a different behaviour on the XEvent
> stack.
> Try to move 
>    if (damageRatio == 1.0)
>       return;
> below the while loop in ::damageNotify (but that wouldn't explain why
> the first repaint unblacks, nor does it match XEvent specs...
> 
> Last thing (buit unrelated to the patch) would be to addDamageFull()
> in TopLevel::setupCompositing() instead of assigning the damage rect
> (latter "lacks" the signal, iff that is the problem here)
I will bisect and then try a bit with the ideas (but I doubt I have the time for it today). It's not a 
big issue in master and at that time of development ;-)

Martin
["signature.asc" (application/pgp-signature)]

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin


[prev in list] [next in list] [prev in thread] [next in thread]