'Re: Review Request: Make presentWindows close after last window'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Make presentWindows close after last window
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2011-05-08 18:07:28
Message-ID: 20110508180728.4619.20542 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100627/#review3205
-----------------------------------------------------------

I am not able to close this one. Could you please close it? Thanks.

- Martin

On March 6, 2011, 3:19 p.m., Marcus Hähnel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100627/
> -----------------------------------------------------------
> 
> (Updated March 6, 2011, 3:19 p.m.)
> 
> 
> Review request for kwin.
> 
> 
> Summary
> -------
> 
> This should fix Bug 262540. It is not the same patch as in the Bugtracker. I \
> listened to Martins advise and made it so that filtering all windows no longer \
> closes the view. 
> This is my first submission so sorry if I did it the wrong way. I'm open to any \
> advise I can get 
> 
> This addresses bug 262540.
> http://bugs.kde.org/show_bug.cgi?id=262540
> 
> 
> Diffs
> -----
> 
> kwin/effects/presentwindows/presentwindows.cpp a07bf62b 
> 
> Diff: http://git.reviewboard.kde.org/r/100627/diff
> 
> 
> Testing
> -------
> 
> Tested against git-master. Filtering out all windows keeps the view open, as soon \
> as the last window is closed the view closes as well. 
> 
> Thanks,
> 
> Marcus
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100627/">http://git.reviewboard.kde.org/r/100627/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am not able to close \
this one. Could you please close it? Thanks.</pre>  <br />

<p>- Martin</p>

<br />
<p>On March 6th, 2011, 3:19 p.m., Marcus Hähnel wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Marcus Hähnel.</div>

<p style="color: grey;"><i>Updated March 6, 2011, 3:19 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This should fix Bug 262540. It is not the same patch as in the \
Bugtracker. I listened to Martins advise and made it so that filtering all windows no \
longer closes the view.

This is my first submission so sorry if I did it the wrong way. I&#39;m open to any \
advise I can get</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested against git-master. Filtering out all windows keeps the view \
open, as soon as the last window is closed the view closes as well.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=262540">262540</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(a07bf62b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100627/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 