'Re: Review Request: Refactor outline code'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Refactor outline code
From:       "Commit Hook" <null () kde ! org>
Date:       2011-04-28 9:19:19
Message-ID: 20110428091919.20963.56562 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100848/#review2940
-----------------------------------------------------------

This review has been submitted with commit 44b83f951aeb3221c43ef3356e466502=
48b673cd by Martin Gr=C3=A4=C3=9Flin.

- Commit

On March 13, 2011, 12:37 p.m., Arthur Arlt wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100848/
> -----------------------------------------------------------
> =

> (Updated March 13, 2011, 12:37 p.m.)
> =

> =

> Review request for kwin.
> =

> =

> Summary
> -------
> =

> This patch refactors the code for outlining geometries to an own class Ou=
tline. It is used by tabbox and quick tiling. There were two similar implem=
entations for both functionalities which are now refactored to a new class =
Outline. This class provides the X implementation for showing and hiding an=
 outline of a given geometry.
> For the future this functionality could be replaced by an effect.
> =

> =

> Diffs
> -----
> =

>   kwin/CMakeLists.txt 976c831 =

>   kwin/geometry.cpp 88719bf =

>   kwin/outline.h PRE-CREATION =

>   kwin/outline.cpp PRE-CREATION =

>   kwin/tabbox.h 1f02b1f =

>   kwin/tabbox.cpp e2d07fe =

>   kwin/tabbox/tabboxhandler.h 96a1fc6 =

>   kwin/tabbox/tabboxhandler.cpp b178efe =

>   kwin/workspace.h fe97c77 =

>   kwin/workspace.cpp 43e3e8c =

> =

> Diff: http://git.reviewboard.kde.org/r/100848/diff
> =

> =

> Testing
> -------
> =

> Quick Tiling and tabbox works with this implementation.
> =

> =

> Thanks,
> =

> Arthur
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100848/">http://git.reviewboard.kde.org/r/100848/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 44b83f951aeb3221c43ef3356e46650248b673cd by Martin \
Gräßlin.</pre>  <br />

<p>- Commit</p>

<br />
<p>On March 13th, 2011, 12:37 p.m., Arthur Arlt wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Arthur Arlt.</div>

<p style="color: grey;"><i>Updated March 13, 2011, 12:37 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch refactors the code for outlining geometries to an own class \
Outline. It is used by tabbox and quick tiling. There were two similar \
implementations for both functionalities which are now refactored to a new class \
Outline. This class provides the X implementation for showing and hiding an outline \
of a given geometry. For the future this functionality could be replaced by an \
effect.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Quick Tiling and tabbox works with this implementation.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/CMakeLists.txt <span style="color: grey">(976c831)</span></li>

 <li>kwin/geometry.cpp <span style="color: grey">(88719bf)</span></li>

 <li>kwin/outline.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kwin/outline.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kwin/tabbox.h <span style="color: grey">(1f02b1f)</span></li>

 <li>kwin/tabbox.cpp <span style="color: grey">(e2d07fe)</span></li>

 <li>kwin/tabbox/tabboxhandler.h <span style="color: grey">(96a1fc6)</span></li>

 <li>kwin/tabbox/tabboxhandler.cpp <span style="color: grey">(b178efe)</span></li>

 <li>kwin/workspace.h <span style="color: grey">(fe97c77)</span></li>

 <li>kwin/workspace.cpp <span style="color: grey">(43e3e8c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100848/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 