[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Remove QHash::operator[] from motionmanager &
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2011-04-27 9:10:18
Message-ID: 20110427091018.13889.73769 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101232/#review2917
-----------------------------------------------------------
Ship it!
Just remove the comments in unmageWindow and ship it if it really doesn't b=
reak ;-)
- Martin
On April 25, 2011, 11:48 p.m., Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101232/
> -----------------------------------------------------------
> =
> (Updated April 25, 2011, 11:48 p.m.)
> =
> =
> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Summary
> -------
> =
> Though secured in many locations, it wasn't in all - and it's still an ov=
erhead ;-)
> =
> I think the qAbs() check was some QnD solution (but incorrect logic) - it=
has no impact on the actual moving but now the motion is finished as soon =
as the distance drop under a certain limit and not (for all but the northwe=
st case) into a certain frame.
> =
> There's still some space for improvement (handle multiple motions as well=
as operating on the center points. both mentioned as TODOs. latter one sho=
ld be pretty simple)
> =
> =
> Diffs
> -----
> =
> kwin/libkwineffects/kwineffects.cpp 45a075a =
> =
> Diff: http://git.reviewboard.kde.org/r/101232/diff
> =
> =
> Testing
> -------
> =
> present windows with extremely slow settings.
> curve is there, "overshoot" not.
> =
> =
> Thanks,
> =
> Thomas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101232/">http://git.reviewboard.kde.org/r/101232/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just remove the comments \
in unmageWindow and ship it if it really doesn't break ;-)</pre> <br />
<p>- Martin</p>
<br />
<p>On April 25th, 2011, 11:48 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated April 25, 2011, 11:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Though secured in many locations, it wasn't in all - and it's \
still an overhead ;-)
I think the qAbs() check was some QnD solution (but incorrect logic) - it has no \
impact on the actual moving but now the motion is finished as soon as the distance \
drop under a certain limit and not (for all but the northwest case) into a certain \
frame.
There's still some space for improvement (handle multiple motions as well as \
operating on the center points. both mentioned as TODOs. latter one shold be pretty \
simple)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">present windows with extremely slow settings. curve is there, \
"overshoot" not.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/libkwineffects/kwineffects.cpp <span style="color: \
grey">(45a075a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101232/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic