'Re: Review Request: Draft for an AnimationEffect'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Draft for an AnimationEffect
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2011-04-25 17:17:39
Message-ID: 20110425171739.30905.78359 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101211/
-----------------------------------------------------------

(Updated April 25, 2011, 5:17 p.m.)

Review request for kwin.

Changes
-------

Opacity handling is implemented and FadeEffect ported. Please give comments=
 on it.

Summary
-------

Attached a draft for a new "AnimationEffect" which will allow to animate wi=
ndows in a generic way without implementing the custom handling in the repa=
int loop. The idea is to export this API to JavaScript and/or QML.

As it's only the header yet please give some feedback what you think about =
the idea and API before I implement it.

Diffs (updated)
-----

  kwin/effects/fade/fade.h c26298a =

  kwin/effects/fade/fade.cpp 52f0e37 =

  kwin/libkwineffects/CMakeLists.txt 32d1c20 =

  kwin/libkwineffects/kwinanimations.cpp PRE-CREATION =

  kwin/libkwineffects/kwinanimations_p.h PRE-CREATION =

  kwin/libkwineffects/kwineffects.h 2310602 =

  kwin/libkwineffects/kwineffects.cpp 45a075a =

Diff: http://git.reviewboard.kde.org/r/101211/diff

Testing
-------

Thanks,

Martin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101211/">http://git.reviewboard.kde.org/r/101211/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated April 25, 2011, 5:17 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Opacity handling is implemented and FadeEffect ported. Please give \
comments on it.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Attached a draft for a new &quot;AnimationEffect&quot; which will allow \
to animate windows in a generic way without implementing the custom handling in the \
repaint loop. The idea is to export this API to JavaScript and/or QML.

As it&#39;s only the header yet please give some feedback what you think about the \
idea and API before I implement it.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/fade/fade.h <span style="color: grey">(c26298a)</span></li>

 <li>kwin/effects/fade/fade.cpp <span style="color: grey">(52f0e37)</span></li>

 <li>kwin/libkwineffects/CMakeLists.txt <span style="color: \
grey">(32d1c20)</span></li>

 <li>kwin/libkwineffects/kwinanimations.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/libkwineffects/kwinanimations_p.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(2310602)</span></li>

 <li>kwin/libkwineffects/kwineffects.cpp <span style="color: \
grey">(45a075a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101211/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 