'Re: Review Request: Make present windows effect not calculate windows'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Make present windows effect not calculate windows
From:       "Commit Hook" <null () kde ! org>
Date:       2011-04-24 12:40:15
Message-ID: 20110424124015.28077.68540 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101180/#review2865
-----------------------------------------------------------

This review has been submitted with commit 888d34eb7a278c7284080c748304308f6f958347 \
by Jan Gerrit Marker.

- Commit

On April 22, 2011, 2:50 p.m., Jan Gerrit Marker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101180/
> -----------------------------------------------------------
> 
> (Updated April 22, 2011, 2:50 p.m.)
> 
> 
> Review request for kwin.
> 
> 
> Summary
> -------
> 
> With this patch the present windows effect does not preserve place for windows from \
> other activites. Previously windows from other activities were not shown but the \
> effect preserved place for them and if one moved the mouse over the place a close \
> button was shown. 
> 
> This addresses bug 242555.
> http://bugs.kde.org/show_bug.cgi?id=242555
> 
> 
> Diffs
> -----
> 
> kwin/effects.h cdfcffe 
> kwin/effects.cpp 8c97995 
> kwin/effects/presentwindows/presentwindows.cpp 816e4a5 
> kwin/libkwineffects/kwineffects.h 0fa7f9e 
> kwin/libkwineffects/kwineffects.cpp 427bf76 
> 
> Diff: http://git.reviewboard.kde.org/r/101180/diff
> 
> 
> Testing
> -------
> 
> Compiled and tested: it works here.
> 
> 
> Thanks,
> 
> Jan Gerrit
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101180/">http://git.reviewboard.kde.org/r/101180/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 888d34eb7a278c7284080c748304308f6f958347 by Jan Gerrit \
Marker.</pre>  <br />

<p>- Commit</p>

<br />
<p>On April 22nd, 2011, 2:50 p.m., Jan Gerrit Marker wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Jan Gerrit Marker.</div>

<p style="color: grey;"><i>Updated April 22, 2011, 2:50 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With this patch the present windows effect does not preserve place for \
windows from other activites. Previously windows from other activities were not shown \
but the effect preserved place for them and if one moved the mouse over the place a \
close button was shown.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled and tested: it works here.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=242555">242555</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects.h <span style="color: grey">(cdfcffe)</span></li>

 <li>kwin/effects.cpp <span style="color: grey">(8c97995)</span></li>

 <li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(816e4a5)</span></li>

 <li>kwin/libkwineffects/kwineffects.h <span style="color: \
grey">(0fa7f9e)</span></li>

 <li>kwin/libkwineffects/kwineffects.cpp <span style="color: \
grey">(427bf76)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101180/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 