'Re: Review Request: prevent swapping desktops w/o explicit button'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: prevent swapping desktops w/o explicit button
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2011-04-23 11:21:41
Message-ID: 20110423112141.18439.35818 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On April 13, 2011, 6:43 p.m., Martin Gräßlin wrote:
> >

pushed to 4.6, porting to master now

- Thomas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101113/#review2618
-----------------------------------------------------------

On April 13, 2011, 6:38 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101113/
> -----------------------------------------------------------
> 
> (Updated April 13, 2011, 6:38 p.m.)
> 
> 
> Review request for kwin.
> 
> 
> Summary
> -------
> 
> Simply traces whether there's actually been a real click-drag, have a master port as well
> It does NOT implement the wish but fixes the bug mentioned in comment #3 or so
> 
> 
> This addresses bug 220088.
>     http://bugs.kde.org/show_bug.cgi?id=220088
> 
> 
> Diffs
> -----
> 
>   kwin/effects/desktopgrid/desktopgrid.h 31a7b76 
>   kwin/effects/desktopgrid/desktopgrid.cpp 37b1058 
> 
> Diff: http://git.reviewboard.kde.org/r/101113/diff
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Thomas
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101113/">http://git.reviewboard.kde.org/r/101113/</a>
  </td>
    </tr>
   </table>
   <br />

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">pushed to 4.6, porting \
to master now</pre> <br />

<p>- Thomas</p>

<br />
<p>On April 13th, 2011, 6:38 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated April 13, 2011, 6:38 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Simply traces whether there&#39;s actually been a real click-drag, have \
a master port as well It does NOT implement the wish but fixes the bug mentioned in \
comment #3 or so</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=220088">220088</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/desktopgrid/desktopgrid.h <span style="color: \
grey">(31a7b76)</span></li>

 <li>kwin/effects/desktopgrid/desktopgrid.cpp <span style="color: \
grey">(37b1058)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101113/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 