[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: fixing BadPixmap errors
From: "Philipp Knechtges" <philipp-dev () knechtges ! com>
Date: 2011-04-20 16:30:15
Message-ID: 20110420163015.26225.38760 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101132/
-----------------------------------------------------------
(Updated April 20, 2011, 4:30 p.m.)
Review request for kwin.
Changes
-------
In this patch, KWin still forces Qt to use the native Graphicssystem.
The BadPixmap errors in the coverswitch effect are resolved using GLTexture=
instead of SceneOpenGL::Texture.
I'm not sure whether one still has to fix the OpenGL ES part of GLTexture t=
o make this work properly and
whether the whole thing works on a big endian system.
Summary
-------
fixes several BadPixmap errors if one is using the QT Raster backend
Diffs (updated)
-----
kwin/libkwineffects/kwinglutils.h e6d3ffb =
kwin/libkwineffects/kwinglutils.cpp 58e8b6e =
kwin/scene_opengl.h 66862a8 =
kwin/scene_opengl.cpp 58ea7d7 =
kwin/scene_opengl_glx.cpp edff792 =
Diff: http://git.reviewboard.kde.org/r/101132/diff
Testing
-------
Thanks,
Philipp
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101132/">http://git.reviewboard.kde.org/r/101132/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Philipp Knechtges.</div>
<p style="color: grey;"><i>Updated April 20, 2011, 4:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In this patch, KWin still forces Qt to use the native Graphicssystem. \
The BadPixmap errors in the coverswitch effect are resolved using GLTexture instead \
of SceneOpenGL::Texture. I'm not sure whether one still has to fix the OpenGL ES \
part of GLTexture to make this work properly and whether the whole thing works on a \
big endian system.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fixes several BadPixmap errors if one is using the QT Raster \
backend</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/libkwineffects/kwinglutils.h <span style="color: \
grey">(e6d3ffb)</span></li>
<li>kwin/libkwineffects/kwinglutils.cpp <span style="color: \
grey">(58e8b6e)</span></li>
<li>kwin/scene_opengl.h <span style="color: grey">(66862a8)</span></li>
<li>kwin/scene_opengl.cpp <span style="color: grey">(58ea7d7)</span></li>
<li>kwin/scene_opengl_glx.cpp <span style="color: grey">(edff792)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101132/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic