'Review Request: Streamline and add some titlebar & frame mouseclick'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: Streamline and add some titlebar & frame mouseclick
From:       "Thomas Lundgaard" <thomaslundgaard () gmail ! com>
Date:       2011-04-09 17:22:43
Message-ID: 20110409172243.29711.28178 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101071/
-----------------------------------------------------------

Review request for kwin.

Summary
-------

I found myself needing the possibility to configure a right mouseclick on t=
he titlebar to minimize the window. I found that this was not possible in t=
he system settings dialog.
I've implemented this option (just a matter of allowing "Minimize" to be wr=
itten to the configuration file) and while I was at it, i reorganized the o=
rdering of the possible mouse actions to be the same in all the combomenus =
and added options where these were not already present. Hopefully you will =
merge it in trunk, as I think it provides a better user experience (for cor=
ner-cases like me :) )

Diffs
-----

  kwin/kcmkwin/kwinoptions/mouse.cpp fa1f7da =

Diff: http://git.reviewboard.kde.org/r/101071/diff

Testing
-------

Thanks,

Thomas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101071/">http://git.reviewboard.kde.org/r/101071/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Thomas Lundgaard.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I found myself needing the possibility to configure a right mouseclick \
on the titlebar to minimize the window. I found that this was not possible in the \
system settings dialog. I&#39;ve implemented this option (just a matter of allowing \
&quot;Minimize&quot; to be written to the configuration file) and while I was at it, \
i reorganized the ordering of the possible mouse actions to be the same in all the \
combomenus and added options where these were not already present. Hopefully you will \
merge it in trunk, as I think it provides a better user experience (for corner-cases \
like me :) )</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/kcmkwin/kwinoptions/mouse.cpp <span style="color: \
grey">(fa1f7da)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101071/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 