'Re: Review Request: Validate/check logarry in lanczos filter (mytery'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Validate/check logarry in lanczos filter (mytery
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2011-04-03 13:31:58
Message-ID: 20110403133158.15450.22824 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100955/#review2347
-----------------------------------------------------------

Ship it!

I hoped one of our users would actually try it. So there is only one way to test: \
commit and see whether we still get the duplicates after 4.6.3 :-)

- Martin

On March 26, 2011, 6:28 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100955/
> -----------------------------------------------------------
> 
> (Updated March 26, 2011, 6:28 p.m.)
> 
> 
> Review request for kwin.
> 
> 
> Summary
> -------
> 
> I'd prefer to have a confirmation on the patch from someone who encounters the bug, \
> but -mystery or not- this likely /is/ the source of the issue and (unlike the \
> crash) won't hurt. So we should just have it in 4.6 and (needs port) master oc.
> 
> 
> This addresses bug 241163.
> http://bugs.kde.org/show_bug.cgi?id=241163
> 
> 
> Diffs
> -----
> 
> kwin/lib/kwinglutils.cpp ecfe492 
> 
> Diff: http://git.reviewboard.kde.org/r/100955/diff
> 
> 
> Testing
> -------
> 
> Compiles, doesn't cause an extra crash ;-)
> 
> 
> Thanks,
> 
> Thomas
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100955/">http://git.reviewboard.kde.org/r/100955/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I hoped one of our users \
would actually try it. So there is only one way to test: commit and see whether we \
still get the duplicates after 4.6.3 :-)</pre>  <br />

<p>- Martin</p>

<br />
<p>On March 26th, 2011, 6:28 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated March 26, 2011, 6:28 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;d prefer to have a confirmation on the patch from someone who \
encounters the bug, but -mystery or not- this likely /is/ the source of the issue and \
(unlike the crash) won&#39;t hurt. So we should just have it in 4.6 and (needs port) \
master oc.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles, doesn&#39;t cause an extra crash ;-)</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=241163">241163</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/lib/kwinglutils.cpp <span style="color: grey">(ecfe492)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100955/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 