Ship it!
please commit tomorrow (both parts), I will then rebase my shadow code on top of it and also merge tomorrow. No need that your code gets broken by me merging first as you uploaded first :-)
- Martin
On March 22nd, 2011, 7:16 p.m., Thomas Lübking wrote:
Review request for kwin.
By Thomas Lübking.
Updated March 22, 2011, 7:16 p.m.
Description
Allows windows (or users via the rule system) to block compositing while they're present.
The user still can resume and re-suspend compositing at any time (but if it has originally been suspended for a blocking client it will be resumed the moment the last blocking client disappears)
Outstanding issue is that the rules to not allow to apply by fullscreen mode.
No real idea how we should handle this (add to rules globally or do some rule specific)
|
Testing
Rule based & "xprop -f _KDE_NET_WM_BLOCK_COMPOSITING 32a -set _KDE_NET_WM_BLOCK_COMPOSITING 1"
No client internal property setting tested (so far) but it should work as well... ;-)
|
Diffs
- kwin/atoms.h (7d5752c)
- kwin/atoms.cpp (5e93b2a)
- kwin/client.h (0d479a0)
- kwin/client.cpp (ec60bde)
- kwin/composite.cpp (6783d32)
- kwin/events.cpp (05cf864)
- kwin/kcmkwin/kwinrules/ruleswidget.h (ca44bf2)
- kwin/kcmkwin/kwinrules/ruleswidget.cpp (f9fc407)
- kwin/kcmkwin/kwinrules/ruleswidgetbase.ui (74ac56b)
- kwin/manage.cpp (135a016)
- kwin/rules.h (87b2055)
- kwin/rules.cpp (9e4136a)
- kwin/workspace.h (3f6ad49)
- kwin/workspace.cpp (3c77511)
View Diff
|