'Re: Review Request: Strip QHash::operator[] from present windows'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Strip QHash::operator[] from present windows
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2011-04-03 13:36:04
Message-ID: 20110403133604.15727.87269 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100832/#review2350
-----------------------------------------------------------

Ship it!

- Martin

On March 30, 2011, 8:23 p.m., Thomas L=C3=BCbking wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100832/
> -----------------------------------------------------------
> =

> (Updated March 30, 2011, 8:23 p.m.)
> =

> =

> Review request for kwin.
> =

> =

> Summary
> -------
> =

> F*** - i forgot to publish it... again :-(
> =

> Forward patch of http://svn.reviewboard.kde.org/r/5762/
> =

> =

> Diffs
> -----
> =

>   kwin/effects/presentwindows/presentwindows.h 4362bc7 =

>   kwin/effects/presentwindows/presentwindows.cpp f9564db =

> =

> Diff: http://git.reviewboard.kde.org/r/100832/diff
> =

> =

> Testing
> -------
> =

> Yes, presented my windows in all modes (and as proxy to desktopgrid)
> =

> =

> Thanks,
> =

> Thomas
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100832/">http://git.reviewboard.kde.org/r/100832/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

<p>- Martin</p>

<br />
<p>On March 30th, 2011, 8:23 p.m., Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated March 30, 2011, 8:23 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">F*** - i forgot to publish it... again :-(

Forward patch of http://svn.reviewboard.kde.org/r/5762/</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, presented my windows in all modes (and as proxy to \
desktopgrid)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/effects/presentwindows/presentwindows.h <span style="color: \
grey">(4362bc7)</span></li>

 <li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(f9564db)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100832/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 