[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Disable Unredirect Fullscreen Windows in Netbook
From: "Marco Martin" <notmart () gmail ! com>
Date: 2011-03-22 18:32:45
Message-ID: 20110322183245.26695.44243 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100919/#review2107
-----------------------------------------------------------
Ship it!
since as we talked, a proper solution that should replace unredirectfullscr=
een is being developed, i'm in favour of killing it in the netbook
- Marco
On March 22, 2011, 5:31 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100919/
> -----------------------------------------------------------
> =
> (Updated March 22, 2011, 5:31 p.m.)
> =
> =
> Review request for kwin, Plasma and Marco Martin.
> =
> =
> Summary
> -------
> =
> Today a colleague at work did a presentation with Plasma Netbook Shell an=
d I noticed some flickering. This can hopefully be solved by disabling unre=
direct fullscreen windows. Unredirect Fullscreen Windows is more or less us=
eless for the formfactor netbook as you do not use it to
> a) play OpenGL games
> b) watch HD videos
> =
> Therefore I think it's the best to just disable it by default. (I'm also =
thinking about switching the default for desktop).
> =
> I think this patch would make sense to be backported to 4.6 or KDE/4.6 or=
foo/bar/4.6 or whatever the current naming scheme is. Maybe this would req=
uire a kconf update script, though.
> =
> =
> Diffs
> -----
> =
> kcontrol/workspaceoptions/workspaceoptions.cpp 834a5dd =
> =
> Diff: http://git.reviewboard.kde.org/r/100919/diff
> =
> =
> Testing
> -------
> =
> it compiles :-)
> =
> =
> Thanks,
> =
> Martin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100919/">http://git.reviewboard.kde.org/r/100919/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">since as we talked, a \
proper solution that should replace unredirectfullscreen is being developed, i'm \
in favour of killing it in the netbook</pre> <br />
<p>- Marco</p>
<br />
<p>On March 22nd, 2011, 5:31 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Plasma and Marco Martin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 22, 2011, 5:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Today a colleague at work did a presentation with Plasma Netbook Shell \
and I noticed some flickering. This can hopefully be solved by disabling unredirect \
fullscreen windows. Unredirect Fullscreen Windows is more or less useless for the \
formfactor netbook as you do not use it to a) play OpenGL games
b) watch HD videos
Therefore I think it's the best to just disable it by default. (I'm also \
thinking about switching the default for desktop).
I think this patch would make sense to be backported to 4.6 or KDE/4.6 or foo/bar/4.6 \
or whatever the current naming scheme is. Maybe this would require a kconf update \
script, though.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it compiles :-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/workspaceoptions/workspaceoptions.cpp <span style="color: \
grey">(834a5dd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100919/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic