--===============1589953077==
Content-Type: multipart/signed;
  boundary="nextPart2468324.QUl7NvS7oQ";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart2468324.QUl7NvS7oQ
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable

I have no replaced all virtuals with signals and slots. Please have a look =
at=20
the branch - I will merge soon if nobody objects to it.

The biggest change is for windowUserMovedResize which I split into three=20
signals: start, update and finish plus an additional signal for maximize=20
changes. This should make it easier to use and removes the strange if first=
=20
and last then maximized part.

There are still a few methods which might be changed to signals:
* reconfigure -> also direct method call
* borderActivated -> returns a boolean, should be possible to refactor so t=
hat=20
we don't need the boolean
* windowInputMouseEvent -> direct method call
* grabbedKeyboardEvent -> direct method call

And there are the chained methods:
* prePaintScreen
* paintScreen
* prePaintWindow
* paintWindow
* drawWindow
* postPaintWindow
* postPaintScreen
* paintEffectFrame
* transformWindowDamage

The postPaint* could be changed into signals as they are not really chained=
=2E=20
TransformWindowDamage is not used by any effect, so could be dropped.

I will probably keep the branch around after merge to do some further=20
refactoring.

Cheers
Martin

--nextPart2468324.QUl7NvS7oQ
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iJwEAAECAAYFAk18ulkACgkQ/umpWjNT6CJ0iwP9FR+wG9VzKlG24kfLVr+nw3kS
tuNvVQTK2F+Ho8Gmpa/0TBJrLpunIW05rMeh90+OwP86Qy9XFqZ9VZEa3foSW+fX
6t1AHsBLzzv0Tlhycu9RTgCWG5JW2GajcboTH/PDfjyMCvD8fiLprGHoX4eu4NZw
L+pwoBJs73c0xQwyAH0=
=8EsH
-----END PGP SIGNATURE-----

--nextPart2468324.QUl7NvS7oQ--

--===============1589953077==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

--===============1589953077==--