This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100606/

committed to git master, since it's currently relevant there.
needs backport decision

- Thomas


On February 7th, 2011, 11:28 p.m., Thomas Lübking wrote:

Review request for kwin and Nikhil Shantanu Marathe.
By Thomas Lübking.

Updated Feb. 7, 2011, 11:28 p.m.

Description

a) per direction protection of maximized clients against configure requests (v'max'd emacs stays max'd)
b) unlink max'd state from geometry, ie. unmaximizable maximized ;-) clients can be restored as well as moved ones (if moving max'd clients is allowed)

note to self: may also affect bugs #243423 & #252255

Testing

Maximized a hell lot of clients.
Quick maximization & quick tiling is preserved.
(optionally) moving of maximized clients is preserved.
Restricted clients like xterm or emacs can be restored (and are otherwise treated as any other maximized client, just that they don't cover the full desktop)

I HAVE NOT TESTED IMPACT ON GENERAL TILING
Mostly because:
a) i've not used it so far anyway
b) i'm not sure how it should behave
c) apparently we need to deal tiling & non-maximizable clients anyway

linked Nikhil who should be author of tiling layout and know better ;-)
Bugs: 252314, 265568

Diffs

  • kwin/client.h (d36ab61)
  • kwin/client.cpp (3641c36)
  • kwin/geometry.cpp (131951c)

View Diff