--===============2041674018== Content-Type: multipart/alternative; boundary="===============7053108429246609082==" --===============7053108429246609082== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100767/#review1814 ----------------------------------------------------------- Ship it! I give you a ship it - if we want to move the shortcut widget later on, we = still can do it ;-) - Martin On Feb. 28, 2011, 9:14 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100767/ > ----------------------------------------------------------- > = > (Updated Feb. 28, 2011, 9:14 p.m.) > = > = > Review request for kwin. > = > = > Summary > ------- > = > "Enabled" only impacts kwin startup - compositing can be de/activated any= time using the global shortcut or dbus interface. > Former init tests are only performed on the first activation (afterwards = suspend/resume just acts as it used to) > The "Use compositing" checkbox does no more disable the config dialog. > Removed the rather pointless suspend button and replaced it with a shortc= ut config (what turned out to be the tricky part of the patch ;-) > = > = > Diffs > ----- > = > kwin/composite.cpp 9d16f68 = > kwin/kcmkwin/kwincompositing/main.h 313db49 = > kwin/kcmkwin/kwincompositing/main.cpp 71e759c = > kwin/kcmkwin/kwincompositing/main.ui 81cb437 = > kwin/options.h e322d51 = > kwin/options.cpp 9caf2b1 = > kwin/scene.cpp b6fb763 = > kwin/workspace.cpp 922de17 = > = > Diff: http://git.reviewboard.kde.org/r/100767/diff > = > = > Testing > ------- > = > Yes > = > = > Screenshots > ----------- > = > New general tab > http://git.reviewboard.kde.org/r/100767/s/87/ > = > = > Thanks, > = > Thomas > = > --===============7053108429246609082== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100767/ |
Ship it!
I give you= a ship it - if we want to move the shortcut widget later on, we still can = do it ;-)
- Martin
On February 28th, 2011, 9:14 p.m., Thomas L=C3=BCbking wrote:
Review request for kwin.
By Thomas L=C3=BCbking.
Updated Feb. 28, 2011, 9:14 p.m. Descripti= on
Testing <= /h1>
Diffs=
Screensho= ts |