From kwin Sun Mar 06 18:10:01 2011 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Sun, 06 Mar 2011 18:10:01 +0000 To: kwin Subject: Re: Review Request: Unify compositing activation Message-Id: <20110306181001.13980.8575 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=129943504317729 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2041674018==" --===============2041674018== Content-Type: multipart/alternative; boundary="===============7053108429246609082==" --===============7053108429246609082== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100767/#review1814 ----------------------------------------------------------- Ship it! I give you a ship it - if we want to move the shortcut widget later on, we = still can do it ;-) - Martin On Feb. 28, 2011, 9:14 p.m., Thomas L=C3=BCbking wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100767/ > ----------------------------------------------------------- > = > (Updated Feb. 28, 2011, 9:14 p.m.) > = > = > Review request for kwin. > = > = > Summary > ------- > = > "Enabled" only impacts kwin startup - compositing can be de/activated any= time using the global shortcut or dbus interface. > Former init tests are only performed on the first activation (afterwards = suspend/resume just acts as it used to) > The "Use compositing" checkbox does no more disable the config dialog. > Removed the rather pointless suspend button and replaced it with a shortc= ut config (what turned out to be the tricky part of the patch ;-) > = > = > Diffs > ----- > = > kwin/composite.cpp 9d16f68 = > kwin/kcmkwin/kwincompositing/main.h 313db49 = > kwin/kcmkwin/kwincompositing/main.cpp 71e759c = > kwin/kcmkwin/kwincompositing/main.ui 81cb437 = > kwin/options.h e322d51 = > kwin/options.cpp 9caf2b1 = > kwin/scene.cpp b6fb763 = > kwin/workspace.cpp 922de17 = > = > Diff: http://git.reviewboard.kde.org/r/100767/diff > = > = > Testing > ------- > = > Yes > = > = > Screenshots > ----------- > = > New general tab > http://git.reviewboard.kde.org/r/100767/s/87/ > = > = > Thanks, > = > Thomas > = > --===============7053108429246609082== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100767/

Ship it!

I give you=
 a ship it - if we want to move the shortcut widget later on, we still can =
do it ;-)

- Martin

On February 28th, 2011, 9:14 p.m., Thomas L=C3=BCbking wrote:

Review request for kwin.

By Thomas L=C3=BCbking.

Updated Feb. 28, 2011, 9:14 p.m.

Descripti= on

"Enabled" only impacts kwin startup - compositing =
can be de/activated anytime using the global shortcut or dbus interface.
Former init tests are only performed on the first activation (afterwards su=
spend/resume just acts as it used to)
The "Use compositing" checkbox does no more disable the config di=
alog.
Removed the rather pointless suspend button and replaced it with a shortcut=
 config (what turned out to be the tricky part of the patch ;-)

Testing <= /h1>

Yes

Diffs=

kwin/composite.cpp (9d16f68)
kwin/kcmkwin/kwincompositing/main.h (313db= 49)
kwin/kcmkwin/kwincompositing/main.cpp (71e= 759c)
kwin/kcmkwin/kwincompositing/main.ui (81cb= 437)
kwin/options.h (e322d51)
kwin/options.cpp (9caf2b1)
kwin/scene.cpp (b6fb763)
kwin/workspace.cpp (922de17)

Screensho= ts

3D"New

--===============7053108429246609082==-- --===============2041674018== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============2041674018==--