From kwin Sun Mar 06 15:19:38 2011 From: =?utf-8?q?Marcus_H=C3=A4hnel?= Date: Sun, 06 Mar 2011 15:19:38 +0000 To: kwin Subject: Re: Review Request: Make presentWindows close after last window Message-Id: <20110306151938.6119.33947 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwin&m=129942481408326 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0044285542==" --===============0044285542== Content-Type: multipart/alternative; boundary="===============6950312488907365625==" --===============6950312488907365625== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100627/ ----------------------------------------------------------- (Updated March 6, 2011, 3:19 p.m.) Review request for kwin. Changes ------- as requested, [] - free Summary ------- This should fix Bug 262540. It is not the same patch as in the Bugtracker. = I listened to Martins advise and made it so that filtering all windows no l= onger closes the view. This is my first submission so sorry if I did it the wrong way. I'm open to= any advise I can get This addresses bug 262540. http://bugs.kde.org/show_bug.cgi?id=3D262540 Diffs (updated) ----- kwin/effects/presentwindows/presentwindows.cpp a07bf62b = Diff: http://git.reviewboard.kde.org/r/100627/diff Testing ------- Tested against git-master. Filtering out all windows keeps the view open, a= s soon as the last window is closed the view closes as well. Thanks, Marcus --===============6950312488907365625== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/100627/

Review request for kwin.
By Marcus H=C3=A4hnel.

Updated March 6, 2011, 3:19 p.m.

Changes 
as requested, [] - free

Descripti= on 

This should fix Bug 262540. It is not the same patch as in t=
he Bugtracker. I listened to Martins advise and made it so that filtering a=
ll windows no longer closes the view.

This is my first submission so sorry if I did it the wrong way. I'm ope=
n to any advise I can get

Testing <= /h1> 
Tested against git-master. Filtering out all windows keeps t=
he view open, as soon as the last window is closed the view closes as well.=
Bugs: 262540

Diffs= (updated)

  • kwin/effects/presentwindows/presentwindows.cpp (a07bf62b)

View Diff
--===============6950312488907365625==-- --===============0044285542== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============0044285542==--