[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Unify compositing activation
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-02-28 21:14:21
Message-ID: 20110228211421.25927.66520 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100767/
-----------------------------------------------------------
(Updated Feb. 28, 2011, 9:14 p.m.)
Review request for kwin.
Changes
-------
fixed some ws, removed a superflous config reload (it's even stated that se=
tupCompositing() will do that ... ;-)
Summary
-------
"Enabled" only impacts kwin startup - compositing can be de/activated anyti=
me using the global shortcut or dbus interface.
Former init tests are only performed on the first activation (afterwards su=
spend/resume just acts as it used to)
The "Use compositing" checkbox does no more disable the config dialog.
Removed the rather pointless suspend button and replaced it with a shortcut=
config (what turned out to be the tricky part of the patch ;-)
Diffs (updated)
-----
kwin/composite.cpp 9d16f68 =
kwin/kcmkwin/kwincompositing/main.h 313db49 =
kwin/kcmkwin/kwincompositing/main.cpp 71e759c =
kwin/kcmkwin/kwincompositing/main.ui 81cb437 =
kwin/options.h e322d51 =
kwin/options.cpp 9caf2b1 =
kwin/scene.cpp b6fb763 =
kwin/workspace.cpp 922de17 =
Diff: http://git.reviewboard.kde.org/r/100767/diff
Testing
-------
Yes
Screenshots
-----------
New general tab
http://git.reviewboard.kde.org/r/100767/s/87/
Thanks,
Thomas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100767/">http://git.reviewboard.kde.org/r/100767/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2011, 9:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fixed some ws, removed a superflous config reload (it's even stated \
that setupCompositing() will do that ... ;-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">"Enabled" only impacts kwin startup - compositing can be \
de/activated anytime using the global shortcut or dbus interface. Former init tests \
are only performed on the first activation (afterwards suspend/resume just acts as it \
used to) The "Use compositing" checkbox does no more disable the config \
dialog. Removed the rather pointless suspend button and replaced it with a shortcut \
config (what turned out to be the tricky part of the patch ;-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/composite.cpp <span style="color: grey">(9d16f68)</span></li>
<li>kwin/kcmkwin/kwincompositing/main.h <span style="color: \
grey">(313db49)</span></li>
<li>kwin/kcmkwin/kwincompositing/main.cpp <span style="color: \
grey">(71e759c)</span></li>
<li>kwin/kcmkwin/kwincompositing/main.ui <span style="color: \
grey">(81cb437)</span></li>
<li>kwin/options.h <span style="color: grey">(e322d51)</span></li>
<li>kwin/options.cpp <span style="color: grey">(9caf2b1)</span></li>
<li>kwin/scene.cpp <span style="color: grey">(b6fb763)</span></li>
<li>kwin/workspace.cpp <span style="color: grey">(922de17)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100767/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100767/s/87/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/27/comp_gen_400x100.jpeg" \
style="border: 1px black solid;" alt="New general tab" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic