[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Make presentWindows close after last window
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-02-28 18:45:16
Message-ID: 20110228184516.18942.34332 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 28, 2011, 4:49 p.m., Martin Gräßlin wrote:
> > Could you please provide a [] free variant as requested by Thomas (we had some \
> > severe issues with it)? After that I'm happy to push the change :-)
ftr: http://svn.reviewboard.kde.org/r/5762/ has never been applied, so the effect is \
still full off QHash::operator[] abuses ;-)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100627/#review1703
-----------------------------------------------------------
On Feb. 12, 2011, 11:18 p.m., Marcus Hähnel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100627/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2011, 11:18 p.m.)
>
>
> Review request for kwin.
>
>
> Summary
> -------
>
> This should fix Bug 262540. It is not the same patch as in the Bugtracker. I \
> listened to Martins advise and made it so that filtering all windows no longer \
> closes the view.
> This is my first submission so sorry if I did it the wrong way. I'm open to any \
> advise I can get
>
> This addresses bug 262540.
> http://bugs.kde.org/show_bug.cgi?id=262540
>
>
> Diffs
> -----
>
> kwin/effects/presentwindows/presentwindows.cpp 12a3f35
>
> Diff: http://git.reviewboard.kde.org/r/100627/diff
>
>
> Testing
> -------
>
> Tested against git-master. Filtering out all windows keeps the view open, as soon \
> as the last window is closed the view closes as well.
>
> Thanks,
>
> Marcus
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100627/">http://git.reviewboard.kde.org/r/100627/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 28th, 2011, 4:49 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Could you please provide a [] free variant as requested by Thomas (we \
had some severe issues with it)? After that I'm happy to push the change \
:-)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ftr: \
http://svn.reviewboard.kde.org/r/5762/ has never been applied, so the effect is still \
full off QHash::operator[] abuses ;-)</pre> <br />
<p>- Thomas</p>
<br />
<p>On February 12th, 2011, 11:18 p.m., Marcus Hähnel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Marcus Hähnel.</div>
<p style="color: grey;"><i>Updated Feb. 12, 2011, 11:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This should fix Bug 262540. It is not the same patch as in the \
Bugtracker. I listened to Martins advise and made it so that filtering all windows no \
longer closes the view.
This is my first submission so sorry if I did it the wrong way. I'm open to any \
advise I can get</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested against git-master. Filtering out all windows keeps the view \
open, as soon as the last window is closed the view closes as well.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=262540">262540</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/presentwindows/presentwindows.cpp <span style="color: \
grey">(12a3f35)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100627/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic