'Re: Review Request: Add GLES support to kcm_opengl'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Add GLES support to kcm_opengl
From:       "Jammy Zhou" <jammy.zhou () linaro ! org>
Date:       2011-02-25 1:53:00
Message-ID: 20110225015300.16478.16294 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Feb. 24, 2011, 4:21 p.m., David Stephen Hubner wrote:
> > Looks good, thanks :)

Thanks, David and Martin.

- Jammy

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100715/#review1627
-----------------------------------------------------------

On Feb. 24, 2011, 1:57 a.m., Jammy Zhou wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100715/
> -----------------------------------------------------------
> =

> (Updated Feb. 24, 2011, 1:57 a.m.)
> =

> =

> Review request for kwin.
> =

> =

> Summary
> -------
> =

> With kwin-gles, kinfocenter should also provide information about OpenGL =
ES2.0 and EGL libraries. So kcm_opengl.so also needs to be ported to GLES2.
> =

> =

> Diffs
> -----
> =

>   kinfocenter/Modules/CMakeLists.txt 45c1abc =

>   kinfocenter/Modules/opengl/CMakeLists.txt 172f405 =

>   kinfocenter/Modules/opengl/opengl.cpp 5a1a077 =

>   kinfocenter/Modules/opengl/openglconfig.h.cmake PRE-CREATION =

> =

> Diff: http://git.reviewboard.kde.org/r/100715/diff
> =

> =

> Testing
> -------
> =

> run kinfocenter, the GLES2/EGL information can be got correctly.
> =

> =

> Thanks,
> =

> Jammy
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100715/">http://git.reviewboard.kde.org/r/100715/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On February 24th, 2011, 4:21 p.m., <b>David \
Stephen Hubner</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Looks good, thanks :) </pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks, David and \
Martin.</pre> <br />

<p>- Jammy</p>

<br />
<p>On February 24th, 2011, 1:57 a.m., Jammy Zhou wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Jammy Zhou.</div>

<p style="color: grey;"><i>Updated Feb. 24, 2011, 1:57 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With kwin-gles, kinfocenter should also provide information about OpenGL \
ES2.0 and EGL libraries. So kcm_opengl.so also needs to be ported to GLES2.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">run kinfocenter, the GLES2/EGL information can be got correctly.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kinfocenter/Modules/CMakeLists.txt <span style="color: \
grey">(45c1abc)</span></li>

 <li>kinfocenter/Modules/opengl/CMakeLists.txt <span style="color: \
grey">(172f405)</span></li>

 <li>kinfocenter/Modules/opengl/opengl.cpp <span style="color: \
grey">(5a1a077)</span></li>

 <li>kinfocenter/Modules/opengl/openglconfig.h.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100715/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 