[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: export WindowGeometry config symbols
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2011-02-14 20:32:27
Message-ID: 20110214203227.18788.56807 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 5, 2011, 7:54 a.m., Martin Gräßlin wrote:
> > I am unsure if it's allowed to go into 4.6. It can be counted as a new feature \
> > even if the code has been in the repository and is part of 4.6 release. I'll ask \
> > someone more competent about release policy about it.
FYI: the feature /is/ promoted in 4.6.0, ie. there's a "configure" button next to the \
effect that will yell an error. we'd at least have to remove the desktop file if we \
cannot add this before 4.7 at all.
> On Feb. 5, 2011, 7:54 a.m., Martin Gräßlin wrote:
> > kwin/effects/configs_builtins.cpp, line 75
> > <http://git.reviewboard.kde.org/r/100571/diff/1/?file=8407#file8407line75>
> >
> > I assume here we will have a whitespace change in master branch...
>
> Martin Gräßlin wrote:
> given sebas comment on the mailing list I think it's fine to also commit in branch \
> :-)
Ok, pushed to branch.
FTR: symbol vis changes afaik _do_ break ABI at least in dll's, but since this one is \
only dlopen'd and not linked, it shouldn't matter at all (since we _add_ a symbol and \
the only known loader is smart enough to not stumble on non present symbols anyway)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100571/#review1237
-----------------------------------------------------------
On Feb. 4, 2011, 8:41 p.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100571/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2011, 8:41 p.m.)
>
>
> Review request for kwin.
>
>
> Summary
> -------
>
> forgot to add this to the original patch of commit ... =\
>
> will forward port as well after accept (or do you want me to do extra requests?)
>
>
> This addresses bug 265272.
> http://bugs.kde.org/show_bug.cgi?id=265272
>
>
> Diffs
> -----
>
> kwin/effects/configs_builtins.cpp ca3b17f
>
> Diff: http://git.reviewboard.kde.org/r/100571/diff
>
>
> Testing
> -------
>
> yes.
>
>
> Thanks,
>
> Thomas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100571/">http://git.reviewboard.kde.org/r/100571/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 5th, 2011, 7:54 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I am unsure if it's allowed to go into 4.6. It can be counted as a \
new feature even if the code has been in the repository and is part of 4.6 release. \
I'll ask someone more competent about release policy about it.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">FYI: the feature /is/ \
promoted in 4.6.0, ie. there's a "configure" button next to the effect \
that will yell an error. we'd at least have to remove the desktop file if we \
cannot add this before 4.7 at all.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 5th, 2011, 7:54 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/100571/diff/1/?file=8407#file8407line75" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/effects/configs_builtins.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KWIN_EFFECT_CONFIG_MULTIPLE( builtins,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">75</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KWIN_EFFECT_CONFIG_SINGLE</span><span class="p">(</span> <span \
class="n">windowgeometry</span><span class="p">,</span> <span \
class="n">WindowGeometryConfig</span> <span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I assume here we will \
have a whitespace change in master branch...</pre> </blockquote>
<p>On February 11th, 2011, 4:48 p.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">given sebas comment on \
the mailing list I think it's fine to also commit in branch :-)</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, pushed \
to branch.
FTR: symbol vis changes afaik _do_ break ABI at least in dll's, but since this \
one is only dlopen'd and not linked, it shouldn't matter at all (since we \
_add_ a symbol and the only known loader is smart enough to not stumble on non \
present symbols anyway)</pre> <br />
<p>- Thomas</p>
<br />
<p>On February 4th, 2011, 8:41 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2011, 8:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">forgot to add this to the original patch of commit ... =\
will forward port as well after accept (or do you want me to do extra \
requests?)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=265272">265272</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/configs_builtins.cpp <span style="color: \
grey">(ca3b17f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100571/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic