'Re: Review Request: Update handling of max's clients'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Update handling of max's clients
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2011-02-07 23:28:40
Message-ID: 20110207232840.26020.41901 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100606/
-----------------------------------------------------------

(Updated Feb. 7, 2011, 11:28 p.m.)

Review request for kwin and Nikhil Shantanu Marathe.

Summary (updated)
-------

a) per direction protection of maximized clients against configure requests (v'max'd \
emacs stays max'd) b) unlink max'd state from geometry, ie. unmaximizable maximized \
;-) clients can be restored as well as moved ones (if moving max'd clients is \
allowed)

note to self: may also affect bugs #243423 & #252255

This addresses bugs 252314 and 265568.
    http://bugs.kde.org/show_bug.cgi?id=252314
    http://bugs.kde.org/show_bug.cgi?id=265568

Diffs
-----

  kwin/client.h d36ab61 
  kwin/client.cpp 3641c36 
  kwin/geometry.cpp 131951c 

Diff: http://git.reviewboard.kde.org/r/100606/diff

Testing
-------

Maximized a hell lot of clients.
Quick maximization & quick tiling is preserved.
(optionally) moving of maximized clients is preserved.
Restricted clients like xterm or emacs can be restored (and are otherwise treated as \
any other maximized client, just that they don't cover the full desktop)

I HAVE NOT TESTED IMPACT ON GENERAL TILING
Mostly because:
a) i've not used it so far anyway
b) i'm not sure how it should behave
c) apparently we need to deal tiling & non-maximizable clients anyway

linked Nikhil who should be author of tiling layout and know better ;-)

Thanks,

Thomas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100606/">http://git.reviewboard.kde.org/r/100606/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Nikhil Shantanu Marathe.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Feb. 7, 2011, 11:28 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">a) per direction protection of maximized clients against configure \
requests (v&#39;max&#39;d emacs stays max&#39;d) b) unlink max&#39;d state from \
geometry, ie. unmaximizable maximized ;-) clients can be restored as well as moved \
ones (if moving max&#39;d clients is allowed)

note to self: may also affect bugs #243423 &amp; #252255</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Maximized a hell lot of clients. Quick maximization &amp; quick tiling \
is preserved. (optionally) moving of maximized clients is preserved.
Restricted clients like xterm or emacs can be restored (and are otherwise treated as \
any other maximized client, just that they don&#39;t cover the full desktop)

I HAVE NOT TESTED IMPACT ON GENERAL TILING
Mostly because:
a) i&#39;ve not used it so far anyway
b) i&#39;m not sure how it should behave
c) apparently we need to deal tiling &amp; non-maximizable clients anyway

linked Nikhil who should be author of tiling layout and know better ;-)</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=252314">252314</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=265568">265568</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/client.h <span style="color: grey">(d36ab61)</span></li>

 <li>kwin/client.cpp <span style="color: grey">(3641c36)</span></li>

 <li>kwin/geometry.cpp <span style="color: grey">(131951c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100606/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 