[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: strip qhash::operator[] from boxswitch
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2011-02-05 20:29:01
Message-ID: 20110205202901.12877.23331 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 5, 2011, 7:57 a.m., Martin Gräßlin wrote:
> > any chance to get it on top of current git (yeah that could be a nasty change)? \
> > Sorry that I forgot about that one. Looking at the number of crashes we really \
> > need that fix in 4.6.1!
It's now in the 4.6 branch - no, wait: "KDE/4.6" ;-)
Will merge it to master and fix whitespace later on.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6355/#review9810
-----------------------------------------------------------
On Jan. 18, 2011, 12:18 a.m., Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6355/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2011, 12:18 a.m.)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Summary
> -------
>
> - strip qhash::operator[] from boxswitch
> - possibly prevents leaking ItemInfos
> - secure some accesses (selected_window), not sure whether this caused the \
> unreproducable crash when used as proxy in coverswitch
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/kwin/effects/boxswitch/boxswitch.cpp 1215178
>
> Diff: http://svn.reviewboard.kde.org/r/6355/diff
>
>
> Testing
> -------
>
> for (int i = 0; i < 5; ++i) // while (!bored)
> {
> xterm; sleep 5; pkill xterm;
> keepPressed(alt+tab);
> }
>
>
> Thanks,
>
> Thomas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6355/">http://svn.reviewboard.kde.org/r/6355/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 5th, 2011, 7:57 a.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">any chance to get it on top of current git (yeah that could be a nasty \
change)? Sorry that I forgot about that one. Looking at the number of crashes we \
really need that fix in 4.6.1!</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's now in the 4.6 \
branch - no, wait: "KDE/4.6" ;-) Will merge it to master and fix whitespace \
later on.</pre> <br />
<p>- Thomas</p>
<br />
<p>On January 18th, 2011, 12:18 a.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Jan. 18, 2011, 12:18 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- strip qhash::operator[] from boxswitch
- possibly prevents leaking ItemInfos
- secure some accesses (selected_window), not sure whether this caused the \
unreproducable crash when used as proxy in coverswitch</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">for (int i = 0; i < 5; ++i) // while (!bored) {
xterm; sleep 5; pkill xterm;
keepPressed(alt+tab);
}</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/kwin/effects/boxswitch/boxswitch.cpp <span \
style="color: grey">(1215178)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6355/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic