From kwin Tue Jan 25 17:48:50 2011 From: Martin =?utf-8?q?Gr=C3=A4=C3=9Flin?= Date: Tue, 25 Jan 2011 17:48:50 +0000 To: kwin Subject: Code Removal Message-Id: <201101251848.58179.kde () martin-graesslin ! com> X-MARC-Message: https://marc.info/?l=kwin&m=129597766829618 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1111853695==" --===============1111853695== Content-Type: multipart/signed; boundary="nextPart1397901.tAbeHdaQi6"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit --nextPart1397901.tAbeHdaQi6 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi all, after the merge of the GLES branch (scheduled for Sunday) I want to drop so= me=20 code which is unused/broken/whatever. * Sharpen effect * ShaderEffect * Shadow effect * SHM and Fallback OpenGL compositing * Xgl support Here a short reasoning: *Sharpen*: bad design due to rendering allways complete screen to FBO and=20 adding shader to it. Usefullnes of effect questionable. *ShaderEffect*: Not used any more after dropping sharpen *Shadow*: Broken since at least 4.5, complex code, contains code copied fro= m=20 scene opengl without backporting bug fixes, responsible for slowdown (acord= ing=20 to bugs) and many more reasons *SHM and Fallback*: all important drivers support TFP properly nowadays. If= it=20 is not supported XRender is the better solution. Makes code more clean. *Xgl: removed from X tree in 2008 - we defaulted to OpenGL compositing in 2= 009=20 so to say it was always obsoleted. In case of objections speak now or be silent forever :-) Cheers Martin P.S. After code removal I will reformat the source code --nextPart1397901.tAbeHdaQi6 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iJsEAAECAAYFAk0/DQMACgkQ/umpWjNT6CIqygP3bVlxjX/XPBrL3uhl+jJ7IoPk o72NzdN/7GUFitOyfkiLNND3+HZqFfweBZtHHoiyyAYQYFFpK2K5F9Ote/hd8j6H PGZhC6ocwhTePZQCZvTeE6TJRzosQ4NV/DH/5SLZdUBO8NcOKyVNrrrcEnALXHFm /cl8BuJndUpIjZEfFw== =sLRv -----END PGP SIGNATURE----- --nextPart1397901.tAbeHdaQi6-- --===============1111853695== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============1111853695==--