[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Port Kwin::TimeLine to QTimeLine
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2011-01-07 20:45:09
Message-ID: 20110107204509.16027.55254 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6283/#review9569
-----------------------------------------------------------
Ship it!
So I am also fine with the change. Just a small thing you cannot know: the =
effect will break binary compatibility, so we need to increase the ABI vers=
ion. We normaly keep a buffer between two versions and the buffer has not b=
een installed on trunk yet. This will be done when I merge the KWin-GLES br=
anch (scheduled for git transition). Therefore please wait with commit afte=
r the merge.
The diff area highlighted to whitespace issues, btw :-)
trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h
<http://svn.reviewboard.kde.org/r/6283/#comment10560>
That's probably an unrelated change ;-)
- Martin
On 2011-01-06 17:05:41, Thomas Richard wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6283/
> -----------------------------------------------------------
> =
> (Updated 2011-01-06 17:05:41)
> =
> =
> Review request for kwin and Sebastian K=C3=BCgler.
> =
> =
> Summary
> -------
> =
> This patch ports the custom Kwin::TimeLine to QTimeLine. I think the main=
reason why it wasn't sub classed in the first place was to able to provide=
custom curves. Since Qt 4.6 this is possible within QTimeLine itself using=
a QEasingCurve (and they have quite a few standardized now).
> =
> I made sure the custom functions like addTime and removeTime still work p=
roperly.
> =
> The only problem I see is that the copy constructor just copies the Curve=
Shape instead of both the CurveShape and the EasingCurve. This is inevitabl=
e I think because there is no way to know which one is really active. I pos=
sible solution would to keep a flag inside the class ourselfs to check whic=
h one is active. I don't think this is needed though as for getting the val=
ue we shouldn't actually copy the TimeLine. It might even be better to work=
with pointers instead. No real need to copy these objects.
> =
> =
> Diffs
> -----
> =
> trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h 1212016 =
> trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.cpp 1212016 =
> =
> Diff: http://svn.reviewboard.kde.org/r/6283/diff
> =
> =
> Testing
> -------
> =
> Tested the following effects that use a timeline:
> *Minimize
> *Slide
> *Coverswitch
> *Translucency
> *...
> =
> =
> Thanks,
> =
> Thomas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6283/">http://svn.reviewboard.kde.org/r/6283/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So I am also fine with \
the change. Just a small thing you cannot know: the effect will break binary \
compatibility, so we need to increase the ABI version. We normaly keep a buffer \
between two versions and the buffer has not been installed on trunk yet. This will be \
done when I merge the KWin-GLES branch (scheduled for git transition). Therefore \
please wait with commit after the merge.
The diff area highlighted to whitespace issues, btw :-)</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/6283/diff/2/?file=43532#file43532line911" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
KWIN_EXPORT EffectWindow</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">911</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">virtual</span> <span class="n">QRect</span> <span \
class="n">geometryWithDeco</span><span class="p">()</span> <span class="o">=</span> \
<span class="mi">0</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's \
probably an unrelated change ;-)</pre> </div>
<br />
<p>- Martin</p>
<br />
<p>On January 6th, 2011, 5:05 p.m., Thomas Richard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Sebastian Kügler.</div>
<div>By Thomas Richard.</div>
<p style="color: grey;"><i>Updated 2011-01-06 17:05:41</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch ports the custom Kwin::TimeLine to QTimeLine. I think the \
main reason why it wasn't sub classed in the first place was to able to provide \
custom curves. Since Qt 4.6 this is possible within QTimeLine itself using a \
QEasingCurve (and they have quite a few standardized now).
I made sure the custom functions like addTime and removeTime still work properly.
The only problem I see is that the copy constructor just copies the CurveShape \
instead of both the CurveShape and the EasingCurve. This is inevitable I think \
because there is no way to know which one is really active. I possible solution would \
to keep a flag inside the class ourselfs to check which one is active. I don't \
think this is needed though as for getting the value we shouldn't actually copy \
the TimeLine. It might even be better to work with pointers instead. No real need to \
copy these objects.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested the following effects that use a timeline:
*Minimize
*Slide
*Coverswitch
*Translucency
*...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h <span style="color: \
grey">(1212016)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.cpp <span style="color: \
grey">(1212016)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6283/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic