--===============0005851907== Content-Type: multipart/alternative; boundary="===============0199161958871344823==" --===============0199161958871344823== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-12-23 20:09:02, Martin Gr=C3=A4=C3=9Flin wrote: > > Do you have an svn account? Trunk is open again, so this can be committ= ed. > > = > > Unfortunately I cannot test it as my KAuth setup is something broken. I don't have an svn account. = I'll test the patch again after christmas and = ping this review request when I've verified it - Mikael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4460/#review9401 ----------------------------------------------------------- On 2010-06-26 15:05:01, Mikael Gerdin wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/4460/ > ----------------------------------------------------------- > = > (Updated 2010-06-26 15:05:01) > = > = > Review request for kwin. > = > = > Summary > ------- > = > Makes KWin's window killer able to kill processes running as other users. > I just re-used the code used in krunner's (and ksysguard's) process lister > to kill processes using elevated privileges. > = > As it works now it only tries to use elevated privileges if kill returns = EPERM. > = > = > This addresses bug 129476. > https://bugs.kde.org/show_bug.cgi?id=3D129476 > = > = > Diffs > ----- > = > /trunk/KDE/kdebase/workspace/kwin/killer/killer.cpp 1143106 = > = > Diff: http://svn.reviewboard.kde.org/r/4460/diff > = > = > Testing > ------- > = > Manual testing by calling the helper app manually and by making a > root-owned X window hang and click the "X" to make kwin try to kill it. > = > = > Thanks, > = > Mikael > = > --===============0199161958871344823== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/4460/

On December 23rd, 2010, 8:09 p.m., Martin G= r=C3=A4=C3=9Flin wrote:
Do you ha=
ve an svn account? Trunk is open again, so this can be committed.

Unfortunately I cannot test it as my KAuth setup is something broken.

I don't=
 have an svn account. =

I'll test the patch again after christmas and =

ping this review request when I've verified it

- Mikael

On June 26th, 2010, 3:05 p.m., Mikael Gerdin wrote:

Review request for kwin.

By Mikael Gerdin.

Updated 2010-06-26 15:05:01

Descripti= on

Makes KWin's window killer able to kill processes runnin=
g as other users.
I just re-used the code used in krunner's (and ksysguard's) process=
 lister
to kill processes using elevated privileges.

As it works now it only tries to use elevated privileges if kill returns EP=
ERM.

Testing <= /h1>

Manual testing by calling the helper app manually and by mak=
ing a
root-owned X window hang and click the "X" to make kwin try to ki=
ll it.

Bugs: 129476

Diffs=

/trunk/KDE/kdebase/workspace/kwin/killer/killer.cpp (1143106)

--===============0199161958871344823==-- --===============0005851907== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============0005851907==--