[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: adjust strict geometry policies
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2010-12-20 18:09:26
Message-ID: 20101220180926.28533.47354 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5871/#review9343
-----------------------------------------------------------
Ship it!
Though I don't like that we fix client bugs, the changes make sense and are probably useful.
- Martin
On 2010-11-16 16:48:08, Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5871/
> -----------------------------------------------------------
>
> (Updated 2010-11-16 16:48:08)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Summary
> -------
>
> Situation as is:
> ================
> - window with constant aspect will by default loose it when maximized (eg. mplayer, NOT fulslcreen. \
> video gets stretched on xv); preventale by rule only
> - windows are allowed to resize them out of the maximizefull state (emcs, gvim), NOT preventable by \
> rules
> - windows (emacs...) may miscalcuate their size (problaby cause of dbl reparenting in kwin) and \
> -because of fixed aspect- enter a minirace with kwin (window resizes, kwin corrects aspect -> window \
> constantly shrinks on every "i fix my own size" attempt), NOT preventable by rules
> Behaviour with the patch:
> =========================
> a) Maximizefull (while being a usage bug ;-) is a userwish, the client should simply not be allowed to \
> resize out of this. period. b) The aspect should (by default) be respected by maximized windows \
> (mplayer, it just doesn't maximize. maybe this techaes ppl. into fs mode ;-)
> -> this hits emacs/gvim as well
> c) If a rule says to disobey geometry limitations (aspect, increments) for a window, this applies \
> always (for maximized as well as unmaxmimized windows). this will allow to prevent the client from \
> shrinking itself (in a race with kwin)
> Consequence:
> ============
> - applying this patch will fix what is imho disbehaviour on mplayer
> - additionally ruling emacs/gvim to NOT strictly obey geometry will allow to workaround the mentioned \
> bugs (which are client bugs: a client is not a WM and it's not its job to care about whether its \
> aspect/increment flag is ultimately honored. period. grrrr... ;-)
>
> This addresses bugs 158974 and 252314.
> https://bugs.kde.org/show_bug.cgi?id=158974
> https://bugs.kde.org/show_bug.cgi?id=252314
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/kwin/geometry.cpp 1196096
>
> Diff: http://svn.reviewboard.kde.org/r/5871/diff
>
>
> Testing
> -------
>
> mplayer, bug 158974 - i /assume/ this will resolve bug 252314 as well, but have no idea how to do \
> "latex" mode in emacs
>
> Thanks,
>
> Thomas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5871/">http://svn.reviewboard.kde.org/r/5871/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Though I don't like that we fix client bugs, the changes make \
sense and are probably useful.</pre> <br />
<p>- Martin</p>
<br />
<p>On November 16th, 2010, 4:48 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left \
top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated 2010-11-16 16:48:08</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Situation as is: ================
- window with constant aspect will by default loose it when maximized (eg. mplayer, NOT fulslcreen. video \
gets stretched on xv); preventale by rule only
- windows are allowed to resize them out of the maximizefull state (emcs, gvim), NOT preventable by rules
- windows (emacs...) may miscalcuate their size (problaby cause of dbl reparenting in kwin) and -because \
of fixed aspect- enter a minirace with kwin (window resizes, kwin corrects aspect -> window constantly \
shrinks on every "i fix my own size" attempt), NOT preventable by rules
Behaviour with the patch:
=========================
a) Maximizefull (while being a usage bug ;-) is a userwish, the client should simply not be allowed to \
resize out of this. period. b) The aspect should (by default) be respected by maximized windows (mplayer, \
it just doesn't maximize. maybe this techaes ppl. into fs mode ;-)
-> this hits emacs/gvim as well
c) If a rule says to disobey geometry limitations (aspect, increments) for a window, this applies always \
(for maximized as well as unmaxmimized windows). this will allow to prevent the client from shrinking \
itself (in a race with kwin)
Consequence:
============
- applying this patch will fix what is imho disbehaviour on mplayer
- additionally ruling emacs/gvim to NOT strictly obey geometry will allow to workaround the mentioned \
bugs (which are client bugs: a client is not a WM and it's not its job to care about whether its \
aspect/increment flag is ultimately honored. period. grrrr... ;-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">mplayer, bug 158974 - i /assume/ this will \
resolve bug 252314 as well, but have no idea how to do "latex" mode in emacs</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=158974">158974</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=252314">252314</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/kwin/geometry.cpp <span style="color: grey">(1196096)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5871/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic