[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: The KWin Coding Style Situation
From:       Martin =?iso-8859-15?q?Gr=E4=DFlin?= <kde () martin-graesslin ! com>
Date:       2010-11-28 20:31:50
Message-ID: 201011282131.57783.kde () martin-graesslin ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 28 November 2010 21:18:55 Chani wrote:
> a new branch? two weeks? why?
> isn't there a program for reformatting code, that could just sweep over all
> of it and be one commit? even if it's not perfect, something that could at
> least fix the brace indentation...
let's say I don't trust it and don't want to possibly degenerate the code 
quality by getting the braces wrong. So waiting for trunk/master open up again 
and testing two weeks for obvious regressions sounds like an idea to me.
> 
> and, svn has the ability to ignore ws changes (which a lot of these changes
> will be). I don't know about git though.
Whitespaces shouldn't be a problem, more the moving of the braces. Those will 
most likely end up in the diff.
if( foo )
	doSomething();
will become
if (foo) {
	doSomething();
}

I doubt that this can be handled by tools.
> 
> I say, get the style conversion over with quick. maybe just do it now
> instead of waiting for git :)

["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]