'Review Request: fix bug 245372, replace some naive code...'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: fix bug 245372, replace some naive code...
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2010-11-07 12:56:48
Message-ID: 20101107125648.19569.38791 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5783/
-----------------------------------------------------------

Review request for kwin.

Summary
-------

a) slideback didn't check for matching VDs on intersection calculation, this \
"somehow" caused issues with the clipping b) the VD match used somewhere else was not \
really complete (only cared about one of the clients being sticky) c) there's some \
really naive code (qregion calculations except for "intersects" is rather slow, so is \
"prepend" to qlist) d) i do not fix present whitespace/indention errors ;-P

This addresses bug 245372.
    https://bugs.kde.org/show_bug.cgi?id=245372

Diffs
-----

  /trunk/KDE/kdebase/workspace/kwin/effects/slideback/slideback.cpp 1193710 

Diff: http://svn.reviewboard.kde.org/r/5783/diff

Testing
-------

one of the bug reporters did. i couldn't reproduce the issue myself - might be other \
effects in the way(?)

Thanks,

Thomas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5783/">http://svn.reviewboard.kde.org/r/5783/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">a) slideback didn&#39;t check for matching VDs on intersection \
calculation, this &quot;somehow&quot; caused issues with the clipping b) the VD match \
used somewhere else was not really complete (only cared about one of the clients \
being sticky) c) there&#39;s some really naive code (qregion calculations except for \
&quot;intersects&quot; is rather slow, so is &quot;prepend&quot; to qlist) d) i do \
not fix present whitespace/indention errors ;-P</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">one of the bug reporters did. i couldn&#39;t reproduce the issue myself \
- might be other effects in the way(?)</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=245372">245372</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/workspace/kwin/effects/slideback/slideback.cpp <span \
style="color: grey">(1193710)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5783/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 