[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Make the invocation of the lanczos filter user
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2010-11-02 21:04:18
Message-ID: 20101102210418.27070.63011 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-10-23 16:24:19, Christoph Feck wrote:
> > Please no tri-state check box. If you need three options, use a combo b=
ox or a radio button.
> =
> Thomas L=C3=BCbking wrote:
> I don't like it too much myself, but didn't want to clutter the UI (m=
ore...) or even break present XRender settings.
> It's gonna be a bigger patch to review then ;-P
> =
> Fredrik H=C3=B6glund wrote:
> The "Texture filter" combobox in the OpenGL section is the equivalent=
of the "Smooth scaling" checkbox in the Xrender section.
> (Smooth scaling means bilinear when checked and nearest-neighbor when=
unchecked.)
>
Technically: yes.
But from a users POV the bilinear texture filter never said "(slower)" (tho=
ugh the css nvidia driver is pretty fast on bilinear xrender scaling - no i=
dea about other HW, though...)
In general i'd perhaps avoid filter terms at all and use sth. like "Crisp",=
"Smooth", "Accurate", "Extra accurate" ... or so (though this would force =
TriLF to get the lanczos filter)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5683/#review8324
-----------------------------------------------------------
On 2010-10-24 00:02:24, Thomas L=C3=BCbking wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5683/
> -----------------------------------------------------------
> =
> (Updated 2010-10-24 00:02:24)
> =
> =
> Review request for kwin.
> =
> =
> Summary
> -------
> =
> Make the invocation of the lanczos filter user configurable.
> =
> Reason:
> We cannot pre-catch every required gpu/driver in the blacklists and since=
blacklists are vendor utils, users cannot be expected to fetch the proper =
driver string and extend the list by themself in case they encounter a prob=
lem.
> =
> Behaviour:
> There's a new "smooth scaling" tristate checkbox, replacing the XRender v=
ariant when selecting the GL backend.
> "On": means the filter is used
> "Off": means the filter is not used
> "Maybe": means to fallback to the blacklist
> =
> =
> Diffs
> -----
> =
> /trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwincompositing/main.h 118685=
8 =
> /trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwincompositing/main.cpp 1186=
858 =
> /trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwincompositing/main.ui 11868=
58 =
> /trunk/KDE/kdebase/workspace/kwin/lanczosfilter.cpp 1186858 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5683/diff
> =
> =
> Testing
> -------
> =
> yes.
> =
> =
> Screenshots
> -----------
> =
> 2010/10/24-0200
> http://svn.reviewboard.kde.org/r/5683/s/542/
> =
> =
> Thanks,
> =
> Thomas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5683/">http://svn.reviewboard.kde.org/r/5683/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 23rd, 2010, 4:24 p.m., <b>Christoph \
Feck</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Please no tri-state check box. If you need three options, use a combo \
box or a radio button.</pre> </blockquote>
<p>On October 23rd, 2010, 4:44 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't like it too \
much myself, but didn't want to clutter the UI (more...) or even break present \
XRender settings. It's gonna be a bigger patch to review then ;-P</pre>
</blockquote>
<p>On November 2nd, 2010, 5:33 p.m., <b>Fredrik Höglund</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The "Texture \
filter" combobox in the OpenGL section is the equivalent of the "Smooth \
scaling" checkbox in the Xrender section. (Smooth scaling means bilinear when \
checked and nearest-neighbor when unchecked.) </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Technically: yes. But \
from a users POV the bilinear texture filter never said "(slower)" (though \
the css nvidia driver is pretty fast on bilinear xrender scaling - no idea about \
other HW, though...)
In general i'd perhaps avoid filter terms at all and use sth. like \
"Crisp", "Smooth", "Accurate", "Extra \
accurate" ... or so (though this would force TriLF to get the lanczos \
filter)</pre> <br />
<p>- Thomas</p>
<br />
<p>On October 24th, 2010, 12:02 a.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated 2010-10-24 00:02:24</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make the invocation of the lanczos filter user configurable.
Reason:
We cannot pre-catch every required gpu/driver in the blacklists and since blacklists \
are vendor utils, users cannot be expected to fetch the proper driver string and \
extend the list by themself in case they encounter a problem.
Behaviour:
There's a new "smooth scaling" tristate checkbox, replacing the XRender \
variant when selecting the GL backend. "On": means the filter is used
"Off": means the filter is not used
"Maybe": means to fallback to the blacklist</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwincompositing/main.h <span \
style="color: grey">(1186858)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwincompositing/main.cpp <span \
style="color: grey">(1186858)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/kcmkwin/kwincompositing/main.ui <span \
style="color: grey">(1186858)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/lanczosfilter.cpp <span style="color: \
grey">(1186858)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5683/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5683/s/542/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/10/24/newcompdlg_400x100.jpeg" \
style="border: 1px black solid;" alt="2010/10/24-0200" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic