[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: Add effect to display the window geometry
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2010-10-24 16:35:58
Message-ID: 20101024163558.15076.10625 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-10-24 16:06:35, Martin Gräßlin wrote:
> > I definately like the idea and want to have it in 4.6, so please add it to the \
> > feature plan (just in case we don't get it in till feature freeze this week).
> > I already thought about the problem of how an effect could interact with kwin \
> > core and vice versa for some time (with exactly this problem in mind). I don't \
> > like the solution for resize effect at all and I doubt that would scale.
> > My idea is to have a EffectsCapability enum in Effect class:
> > enum EffectsCapabilities {
> > ProvidesResize,
> > ProvidesGeometryTip // ....
> > }
> >
> > and have an
> > virtual boolean Effect::providesCapability(EffectCapabilities capability) const; \
> > returning false by default.
> > In EffectsHandlerImpl we could have a boolean \
> > EffectsHandlerImpl::capabilityAvailable(EffectsCapabilites capability) const; \
> > which goes through all loaded effects and returns true as soon as one is found \
> > which provides the capability.
> > For the question of how the effect could know about when it should render the \
> > geometry tip or not I think there is only one option: open the kwin general \
> > configuration. That way we could get rid of the configuration interface at all \
> > ;-)
> > Now to the effect: I have one question: why does it need three EffectFrames?
added planned feature.
> why does it need three EffectFrames?
information overflow ;-)
(topleft corner coords (+delta), bottomright corner coords (+delta), center either \
has geometry translation or size modulation)
splitting information allows you to easily focus on your interest (precise edge \
positioning / size, or position/size delta)
- if you'd put everything into one frame it would be quite crowded... =\
of course we could skip bottom left info and just reduce the information to the \
present - has higher entropy, so you'll also need a calculator ;-P
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5684/#review8334
-----------------------------------------------------------
On 2010-10-24 15:06:40, Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5684/
> -----------------------------------------------------------
>
> (Updated 2010-10-24 15:06:40)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Summary
> -------
>
> Adds an effect based window geometry indicator (on move/resize)
>
> Reason:
> The present indicator is reported to be slow with several gpus (ati?)
>
> Todo:
> * Might require integration with the general setting (ie. silently activate the \
> effect with the setting and use it instead depending on the compositing state) but \
> this would "hardcode" this effect (the other solution was to do the same as on the \
> resize effect but maybe that's overly complex)
> * One or two whitespace issues... :-(
> -> to be fixed with or without the integration (iff)
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt 1186858
> /trunk/KDE/kdebase/workspace/kwin/effects/windowgeometry/CMakeLists.txt \
> PRE-CREATION
> /trunk/KDE/kdebase/workspace/kwin/effects/windowgeometry/windowgeometry.desktop \
> PRE-CREATION
> /trunk/KDE/kdebase/workspace/kwin/effects/windowgeometry/windowgeometry.h \
> PRE-CREATION
> /trunk/KDE/kdebase/workspace/kwin/effects/windowgeometry/windowgeometry.cpp \
> PRE-CREATION
> /trunk/KDE/kdebase/workspace/kwin/effects/windowgeometry/windowgeometry_config.cpp \
> PRE-CREATION
> /trunk/KDE/kdebase/workspace/kwin/effects/windowgeometry/windowgeometry_config.desktop \
> PRE-CREATION
> /trunk/KDE/kdebase/workspace/kwin/effects/windowgeometry/windowgeometry_config.h \
> PRE-CREATION
> /trunk/KDE/kdebase/workspace/kwin/effects/windowgeometry/windowgeometry_config.ui \
> PRE-CREATION
> Diff: http://svn.reviewboard.kde.org/r/5684/diff
>
>
> Testing
> -------
>
> Moved around some windows =D
>
>
> Thanks,
>
> Thomas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5684/">http://svn.reviewboard.kde.org/r/5684/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 24th, 2010, 4:06 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I definately like the idea and want to have it in 4.6, so please add it \
to the feature plan (just in case we don't get it in till feature freeze this \
week).
I already thought about the problem of how an effect could interact with kwin core \
and vice versa for some time (with exactly this problem in mind). I don't like \
the solution for resize effect at all and I doubt that would scale.
My idea is to have a EffectsCapability enum in Effect class:
enum EffectsCapabilities {
ProvidesResize,
ProvidesGeometryTip // ....
}
and have an
virtual boolean Effect::providesCapability(EffectCapabilities capability) const; \
returning false by default.
In EffectsHandlerImpl we could have a boolean \
EffectsHandlerImpl::capabilityAvailable(EffectsCapabilites capability) const; which \
goes through all loaded effects and returns true as soon as one is found which \
provides the capability.
For the question of how the effect could know about when it should render the \
geometry tip or not I think there is only one option: open the kwin general \
configuration. That way we could get rid of the configuration interface at all ;-)
Now to the effect: I have one question: why does it need three EffectFrames?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">added planned feature.
> why does it need three EffectFrames?
information overflow ;-)
(topleft corner coords (+delta), bottomright corner coords (+delta), center either \
has geometry translation or size modulation)
splitting information allows you to easily focus on your interest (precise edge \
positioning / size, or position/size delta)
- if you'd put everything into one frame it would be quite crowded... =\
of course we could skip bottom left info and just reduce the information to the \
present - has higher entropy, so you'll also need a calculator ;-P</pre> <br />
<p>- Thomas</p>
<br />
<p>On October 24th, 2010, 3:06 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated 2010-10-24 15:06:40</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds an effect based window geometry indicator (on move/resize)
Reason:
The present indicator is reported to be slow with several gpus (ati?)
Todo:
* Might require integration with the general setting (ie. silently activate the \
effect with the setting and use it instead depending on the compositing state) but \
this would "hardcode" this effect (the other solution was to do the same as \
on the resize effect but maybe that's overly complex)
* One or two whitespace issues... :-(
-> to be fixed with or without the integration (iff)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Moved around some windows =D</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt <span style="color: \
grey">(1186858)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/effects/windowgeometry/CMakeLists.txt <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/effects/windowgeometry/windowgeometry.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/effects/windowgeometry/windowgeometry.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/effects/windowgeometry/windowgeometry.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/effects/windowgeometry/windowgeometry_config.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/effects/windowgeometry/windowgeometry_config.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/effects/windowgeometry/windowgeometry_config.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/effects/windowgeometry/windowgeometry_config.ui \
<span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5684/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic