'Re: Review Request: Relaxed utility hiding'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: Relaxed utility hiding
From:       Thomas_Lübking <thomas.luebking () web ! de>
Date:       2010-10-23 16:07:57
Message-ID: 20101023160757.18893.54619 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/4007/
-----------------------------------------------------------

(Updated 2010-10-23 16:07:57.467807)

Review request for kwin and Lubos Lunak.

Changes
-------

just explicitly attaching Seli, assuming he's the only person in charge & p=
osition to decide this.

Summary
-------

... aka "TheGimp situation"

Instead of looking for Client::mainClients() (what's always an empty list i=
n case isTransient() is false) i'd suggest to just look whether there's a "=
normal" member* in the group that can be activated - what should be suffici=
ent to safely hide the utility window when the group falls inactive.

There's bug #152342 which i cannot confirm, so it has been either fixed mea=
nwhile or it derives from the lack of a transient hint.

*this is actually more restrictive than !isSpecialWindow, what does not exc=
lude other utility windows (which should however afaics not become mainClie=
nts...)

Diffs
-----

  /trunk/KDE/kdebase/workspace/kwin/workspace.cpp 1127512 =

Diff: http://svn.reviewboard.kde.org/r/4007/diff

Testing
-------

Gimp, most prominent representative of this issue.
Qt docks which set the transient hint and remain working as well.

Thanks,

Thomas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/4007/">http://svn.reviewboard.kde.org/r/4007/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Lubos Lunak.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated 2010-10-23 16:07:57.467807</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">just explicitly attaching Seli, assuming he&#39;s the only person in \
charge &amp; position to decide this.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">... aka &quot;TheGimp situation&quot;

Instead of looking for Client::mainClients() (what&#39;s always an empty list in case \
isTransient() is false) i&#39;d suggest to just look whether there&#39;s a \
&quot;normal&quot; member* in the group that can be activated - what should be \
sufficient to safely hide the utility window when the group falls inactive.

There&#39;s bug #152342 which i cannot confirm, so it has been either fixed meanwhile \
or it derives from the lack of a transient hint.

*this is actually more restrictive than !isSpecialWindow, what does not exclude other \
utility windows (which should however afaics not become mainClients...)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Gimp, most prominent representative of this issue. Qt docks which set \
the transient hint and remain working as well.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/KDE/kdebase/workspace/kwin/workspace.cpp <span style="color: \
grey">(1127512)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/4007/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

[prev in list] [next in list] [prev in thread] [next in thread] 