[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: catch dangleing pointer in desktopgrid,
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2010-10-19 18:42:06
Message-ID: 20101019184206.12316.94903 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-10-19 17:46:42, Martin Gräßlin wrote:
> > Though I really don't get why it only crashes with XRender... looks good. There \
> > are just some coding style issues ;-)
I'm pretty sure that no other product /that/ many CS violations to remark ;-P
About the segfault:
It's probably just about timings and XRender is just a good way to reproduce it \
(there're more reports on this, not sure whether they all use XRender...) Also it \
does not happen everytime but just if you put the system under stress (i.e. keeping \
it toggled does not instantly segfault but on the 3rd or 4th iteration here...)
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5652/#review8237
-----------------------------------------------------------
On 2010-10-18 16:36:17, Thomas Lübking wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5652/
> -----------------------------------------------------------
>
> (Updated 2010-10-18 16:36:17)
>
>
> Review request for kwin.
>
>
> Summary
> -------
>
> catch dangeling pointer condition - "if (*i)" was actually not enough
>
>
> This addresses bug 244813.
> https://bugs.kde.org/show_bug.cgi?id=244813
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/kwin/effects/desktopgrid/desktopgrid.h 1186858
> /trunk/KDE/kdebase/workspace/kwin/effects/desktopgrid/desktopgrid.cpp 1186858
>
> Diff: http://svn.reviewboard.kde.org/r/5652/diff
>
>
> Testing
> -------
>
> yes :-P
>
> xrender + keeping ctrl+f8 pressed. leads to reproducable segfaults/aborts w/o patch \
> and none with.
>
> Thanks,
>
> Thomas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5652/">http://svn.reviewboard.kde.org/r/5652/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 19th, 2010, 5:46 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Though I really don't get why it only crashes with XRender... looks \
good. There are just some coding style issues ;-)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm pretty sure that \
no other product /that/ many CS violations to remark ;-P
About the segfault:
It's probably just about timings and XRender is just a good way to reproduce it \
(there're more reports on this, not sure whether they all use XRender...) Also it \
does not happen everytime but just if you put the system under stress (i.e. keeping \
it toggled does not instantly segfault but on the 3rd or 4th iteration here...)</pre> \
<br />
<p>- Thomas</p>
<br />
<p>On October 18th, 2010, 4:36 p.m., Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated 2010-10-18 16:36:17</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">catch dangeling pointer condition - "if (*i)" was actually not \
enough</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">yes :-P
xrender + keeping ctrl+f8 pressed. leads to reproducable segfaults/aborts w/o patch \
and none with.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=244813">244813</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/kwin/effects/desktopgrid/desktopgrid.h <span \
style="color: grey">(1186858)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/effects/desktopgrid/desktopgrid.cpp <span \
style="color: grey">(1186858)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5652/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic