[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: Review Request: new kwin effect: roundedcorners - make corners of
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2010-09-21 20:41:33
Message-ID: 20100921204133.31270.18388 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5225/#review7713
-----------------------------------------------------------


I am still rather opposed to include this effect in a default workspace set=
up. I really like the work you are putting into it, but I think that this e=
ffect is hardly used by anyone and is not something that belongs into a def=
ault setup. And we should not include everything and the kitchensink becaus=
e we can do it (therefore we have Compiz, see http://smspillaz.wordpress.co=
m/2010/09/15/philosophy/ ). I am also unhappy with some of the effects we c=
urrently ship (including snow, which was written by me), so this is more a =
general thing. I think such effects should go to either kdeartwork, kdeplas=
ma-addons or extragear. Till we have found a nice solution I would recommen=
d to publish on kde-look/apps (although that is also not so nice as we tend=
 to break the ABI).


tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners=
.cpp
<http://svn.reviewboard.kde.org/r/5225/#comment7832>

    This check looks superfluous. In line 35 you set glTexture to 0, so for=
 both xrender and opengl the pointer is at least 0. As deleting null pointe=
rs is save you can get rid of the if statement and I think also of the #ifd=
ef.


- Martin


On 2010-09-21 18:34:04, Christoph Fritz wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5225/
> -----------------------------------------------------------
> =

> (Updated 2010-09-21 18:34:04)
> =

> =

> Review request for kwin, Plasma, Martin Gr=C3=A4=C3=9Flin, and Thomas L=
=C3=BCbking.
> =

> =

> Summary
> -------
> =

> Inspired by roundedge http://www.nongnu.org/roundedge/ this kwin effect m=
akes corners of the desktop rounded.
> Older Macs and Monitors had this feature too.
> =

> =

> Diffs
> -----
> =

>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/CMakeLists.txt 1170001 =

>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/configs_builtins.cpp 1170=
001 =

>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/CMakeLists=
.txt PRE-CREATION =

>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcor=
ners.desktop PRE-CREATION =

>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcor=
ners.h PRE-CREATION =

>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcor=
ners.cpp PRE-CREATION =

>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcor=
ners_config.h PRE-CREATION =

>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcor=
ners_config.cpp PRE-CREATION =

>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcor=
ners_config.desktop PRE-CREATION =

>   tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcor=
ners_config.ui PRE-CREATION =

> =

> Diff: http://svn.reviewboard.kde.org/r/5225/diff
> =

> =

> Testing
> -------
> =

> =

> Screenshots
> -----------
> =

> roundedcorners_without_frame
>   http://svn.reviewboard.kde.org/r/5225/s/498/
> with_simulated_border
>   http://svn.reviewboard.kde.org/r/5225/s/499/
> =

> =

> Thanks,
> =

> Christoph
> =

>


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5225/">http://svn.reviewboard.kde.org/r/5225/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am still rather \
opposed to include this effect in a default workspace setup. I really like the work \
you are putting into it, but I think that this effect is hardly used by anyone and is \
not something that belongs into a default setup. And we should not include everything \
and the kitchensink because we can do it (therefore we have Compiz, see \
http://smspillaz.wordpress.com/2010/09/15/philosophy/ ). I am also unhappy with some \
of the effects we currently ship (including snow, which was written by me), so this \
is more a general thing. I think such effects should go to either kdeartwork, \
kdeplasma-addons or extragear. Till we have found a nice solution I would recommend \
to publish on kde-look/apps (although that is also not so nice as we tend to break \
the ABI).</pre>  <br />





<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/5225/diff/4/?file=36720#file36720line42" style="color: black; font-weight: \
bold; text-decoration: \
underline;">tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.cpp</a>
  <span style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">RoundedCornersEffect::~RoundedCornersEffect()</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">42</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#ifdef KWIN_HAVE_OPENGL_COMPOSITING</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">43</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span> <span class="p">(</span> <span class="n">glTexture</span> <span \
class="p">)</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">44</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="p">{</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">45</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="k">delete</span> <span class="n">glTexture</span><span \
class="p">;</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">46</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="p">}</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">47</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#endif</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This check \
looks superfluous. In line 35 you set glTexture to 0, so for both xrender and opengl \
the pointer is at least 0. As deleting null pointers is save you can get rid of the \
if statement and I think also of the #ifdef.</pre> </div>
<br />



<p>- Martin</p>


<br />
<p>On September 21st, 2010, 6:34 p.m., Christoph Fritz wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.</div>
<div>By Christoph Fritz.</div>


<p style="color: grey;"><i>Updated 2010-09-21 18:34:04</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Inspired by roundedge http://www.nongnu.org/roundedge/ this kwin effect \
makes corners of the desktop rounded. Older Macs and Monitors had this feature \
too.</pre>  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/CMakeLists.txt <span style="color: \
grey">(1170001)</span></li>

 <li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/configs_builtins.cpp <span \
style="color: grey">(1170001)</span></li>

 <li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/CMakeLists.txt \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.h \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.h \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.ui \
<span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5225/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://svn.reviewboard.kde.org/r/5225/s/498/"><img \
src="http://svn.reviewboard.kde.org" style="border: 1px black solid;" \
alt="roundedcorners_without_frame" /></a>

 <a href="http://svn.reviewboard.kde.org/r/5225/s/499/"><img \
src="http://svn.reviewboard.kde.org" style="border: 1px black solid;" \
alt="with_simulated_border" /></a>

</div>


  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic