[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: new kwin effect: roundedcorners - make corners of
From: "Christoph Fritz" <chf.fritz () googlemail ! com>
Date: 2010-09-21 18:34:05
Message-ID: 20100921183405.26647.30720 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5225/
-----------------------------------------------------------
(Updated 2010-09-21 18:34:04.841960)
Review request for kwin, Plasma, Martin Gr=C3=A4=C3=9Flin, and Thomas L=C3=
=BCbking.
Changes
-------
- add xrender support
- coding style
This effect doesn't hurt, is small and looks neat. It takes angular out and=
coherence with the rounded corners of windows, kicker, ... in.
Maybe the default width of 25 pixels is too much. What do you think?
Summary
-------
Inspired by roundedge http://www.nongnu.org/roundedge/ this kwin effect mak=
es corners of the desktop rounded.
Older Macs and Monitors had this feature too.
Diffs (updated)
-----
tags/KDE/4.5.1/kdebase/workspace/kwin/effects/CMakeLists.txt 1170001 =
tags/KDE/4.5.1/kdebase/workspace/kwin/effects/configs_builtins.cpp 117000=
1 =
tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/CMakeLists.t=
xt PRE-CREATION =
tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorne=
rs.desktop PRE-CREATION =
tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorne=
rs.h PRE-CREATION =
tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorne=
rs.cpp PRE-CREATION =
tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorne=
rs_config.h PRE-CREATION =
tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorne=
rs_config.cpp PRE-CREATION =
tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorne=
rs_config.desktop PRE-CREATION =
tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorne=
rs_config.ui PRE-CREATION =
Diff: http://svn.reviewboard.kde.org/r/5225/diff
Testing
-------
Screenshots
-----------
roundedcorners_without_frame
http://svn.reviewboard.kde.org/r/5225/s/498/
with_simulated_border
http://svn.reviewboard.kde.org/r/5225/s/499/
Thanks,
Christoph
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5225/">http://svn.reviewboard.kde.org/r/5225/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Plasma, Martin Gräßlin, and Thomas Lübking.</div>
<div>By Christoph Fritz.</div>
<p style="color: grey;"><i>Updated 2010-09-21 18:34:04.841960</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- add xrender support
- coding style
This effect doesn't hurt, is small and looks neat. It takes angular out and \
coherence with the rounded corners of windows, kicker, ... in. Maybe the default \
width of 25 pixels is too much. What do you think?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Inspired by roundedge http://www.nongnu.org/roundedge/ this kwin effect \
makes corners of the desktop rounded. Older Macs and Monitors had this feature \
too.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/CMakeLists.txt <span style="color: \
grey">(1170001)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/configs_builtins.cpp <span \
style="color: grey">(1170001)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/CMakeLists.txt \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.ui \
<span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5225/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5225/s/498/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/07/snappi_400x100.png" \
style="border: 1px black solid;" alt="roundedcorners_without_frame" /></a>
<a href="http://svn.reviewboard.kde.org/r/5225/s/499/"><img \
src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/09/07/snappi_with_simulated_border_400x100.png" \
style="border: 1px black solid;" alt="with_simulated_border" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic