From kwin  Thu Sep 09 18:03:08 2010
From: Thomas =?iso-8859-15?q?L=FCbking?= <thomas.luebking () web ! de>
Date: Thu, 09 Sep 2010 18:03:08 +0000
To: kwin
Subject: Re: FIX for XSYNC issue, bugs 178269, 183263, 241094,
Message-Id: <201009092003.08879.thomas.luebking () web ! de>
X-MARC-Message: https://marc.info/?l=kwin&m=128405567723438
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--Boundary-00=_cFSiM5tK6CLvTgd"

--Boundary-00=_cFSiM5tK6CLvTgd
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable

errr.. BUMP...?!

since comment #15 of bug #178269 confirms this patch fixes it and this bug=
=20
sounds pretty severe (if you're hit, kwin is unusuble and deactivating=20
compositing won't help) and i can confirm a fix for the testcase in the oth=
er=20
bug and the worst case (i don't think so, but...) would be that XSYNC isn't=
=20
invoked at all, i'd like to hear either=20
=2D a strict VETO or=20
=2D (preferably) "ship it" or=20
=2D will just dare to COMMIT IT "IN A FEW DAYS" (sorry for shouting)

Cheers,
Thomas


Am Thursday 15 July 2010 schrieb Thomas L=FCbking:
> as clemens kindly provided a testcase on bug 243094 and after testing the
> code a bit i think i found the source of the issue and a fix.
>=20
> disclaimer:
> i've no knowledge about the protocol design at all, sorry
>=20
> it turned out that if a second sync request is send to the client before a
> sync event is received this seems to mess up things in the client and no
> more sync events are received in kwin for that client.
>=20
> the solution was to move the unconditioned "sync_resize_pending =3D false=
;"
> into the Client::syncEvent()
>=20
> this fixes the testcase, it will no more fallback to the sync timer (noti=
ce
> that a 10 second block after 50 resize events in the testcase is intended
> and raises the issue)
>=20
> i also tested a(n unsync')d wine client w/o any regression.
>=20
> it would be great if whoever wrote the XSYNC code could have a look into
> this solution and merge it or give an Ok to commit.
>=20
> Thanks,
> Thomas


--Boundary-00=_cFSiM5tK6CLvTgd
Content-Type: text/x-patch;
  charset="UTF-8";
  name="fix_178269_et_al.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="fix_178269_et_al.diff"

Index: events.cpp
===================================================================
--- events.cpp	(Revision 1149465)
+++ events.cpp	(Arbeitskopie)
@@ -1698,6 +1698,7 @@
             sync_timeout = NULL;
             if( sync_resize_pending )
                 performMoveResize();
+            sync_resize_pending = false;
             }
         }
     }
Index: geometry.cpp
===================================================================
--- geometry.cpp	(Revision 1149465)
+++ geometry.cpp	(Arbeitskopie)
@@ -3299,7 +3299,6 @@
         sendSyncRequest();
         }
 #endif
-    sync_resize_pending = false;
     if( transparent )
         {
         if( !haveResizeEffect )

--Boundary-00=_cFSiM5tK6CLvTgd
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

--Boundary-00=_cFSiM5tK6CLvTgd--