[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: new kwin effect: roundedcorners - make corners of
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2010-09-01 16:42:19
Message-ID: 20100901164219.13170.62367 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5225/#review7350
-----------------------------------------------------------
To be honest I do not see the usefulness of such an effect :-)
If I understand your code correctly you are creating four GL Textures for t=
he corners. That are three too many. Mirroring textures is very easy in Ope=
nGL. In general I would prefer if such eyecandy stuff only uses GLSL (which=
raises the requirements to OpenGL 2). So you would just specify one VBO an=
d use vertex attributes to indicate the corner and do the mirroring in the =
fragment shader. This would also add the possibility to easily do nice radi=
ant fade outs, so that only the pixel nearest to the corner is black while =
the other parts are translucent.
It would be nice if you could attach a screenshot and please get feedback f=
rom Oxygen (designers) and please add Plasma to the groups as well. This is=
heavily influencing the look of the Plasma Workspace, so they should also =
have their say on it.
Oh and please have a look on the HACKING file in kwin source directory for =
coding style.
tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners=
.h
<http://reviewboard.kde.org/r/5225/#comment7525>
Is there a reason why you inherit from QObject? I do not see any slots =
or QObject parent deletion, etc. in the code.
tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners=
.cpp
<http://reviewboard.kde.org/r/5225/#comment7526>
seems to be unused?
tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners=
.cpp
<http://reviewboard.kde.org/r/5225/#comment7524>
please use glDisable(GL_BLEND) as the attribute stack is deprecated and=
causes problems for porting to OpenGL ES and OpenGL 3.
=
KWin source code will soon be changed to just push all attributes on in=
itialization and pop all attributes on shutdown, so that they can easily be=
ifdefed.
=
And doing these state changes each time in the loop is rather inefficie=
nt ;-)
- Martin
On 2010-09-01 14:48:42, Christoph Fritz wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5225/
> -----------------------------------------------------------
> =
> (Updated 2010-09-01 14:48:42)
> =
> =
> Review request for kwin and Martin Gr=C3=A4=C3=9Flin.
> =
> =
> Summary
> -------
> =
> Inspired by roundedge http://www.nongnu.org/roundedge/ this kwin effect m=
akes corners of the desktop rounded.
> Older Macs and Monitors had this feature too.
> =
> =
> Diffs
> -----
> =
> tags/KDE/4.5.1/kdebase/workspace/kwin/effects/CMakeLists.txt 1170001 =
> tags/KDE/4.5.1/kdebase/workspace/kwin/effects/configs_builtins.cpp 1170=
001 =
> tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/CMakeLists=
.txt PRE-CREATION =
> tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcor=
ners.desktop PRE-CREATION =
> tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcor=
ners.h PRE-CREATION =
> tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcor=
ners.cpp PRE-CREATION =
> tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcor=
ners_config.h PRE-CREATION =
> tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcor=
ners_config.cpp PRE-CREATION =
> tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcor=
ners_config.desktop PRE-CREATION =
> tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcor=
ners_config.ui PRE-CREATION =
> =
> Diff: http://reviewboard.kde.org/r/5225/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Christoph
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5225/">http://reviewboard.kde.org/r/5225/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To be honest I do not \
see the usefulness of such an effect :-)
If I understand your code correctly you are creating four GL Textures for the \
corners. That are three too many. Mirroring textures is very easy in OpenGL. In \
general I would prefer if such eyecandy stuff only uses GLSL (which raises the \
requirements to OpenGL 2). So you would just specify one VBO and use vertex \
attributes to indicate the corner and do the mirroring in the fragment shader. This \
would also add the possibility to easily do nice radiant fade outs, so that only the \
pixel nearest to the corner is black while the other parts are translucent.
It would be nice if you could attach a screenshot and please get feedback from Oxygen \
(designers) and please add Plasma to the groups as well. This is heavily influencing \
the look of the Plasma Workspace, so they should also have their say on it.
Oh and please have a look on the HACKING file in kwin source directory for coding \
style.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5225/diff/1/?file=34932#file34932line31" style="color: black; font-weight: \
bold; text-decoration: \
underline;">tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">class RoundedCornersEffect</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">31</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="o">:</span> <span class="n">public</span> <span class="n">QObject</span><span \
class="p">,</span> <span class="n">public</span> <span \
class="n">Effect</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">32</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">33</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Q_OBJECT</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is there a \
reason why you inherit from QObject? I do not see any slots or QObject parent \
deletion, etc. in the code.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5225/diff/1/?file=34933#file34933line50" style="color: black; font-weight: \
bold; text-decoration: \
underline;">tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">RoundedCornersEffect::~RoundedCornersEffect()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">50</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">void</span> <span class="n">RoundedCornersEffect</span><span \
class="o">::</span><span class="n">cleanup</span><span class="p">()</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">51</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">52</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">53</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">seems to be \
unused?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="/r/5225/diff/1/?file=34933#file34933line101" style="color: black; font-weight: \
bold; text-decoration: \
underline;">tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">RoundedCornersEffect::~RoundedCornersEffect()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">101</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">glPushAttrib</span><span class="p">(</span><span \
class="n">GL_CURRENT_BIT</span> <span class="o">|</span> <span \
class="n">GL_ENABLE_BIT</span><span class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">102</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">glPicture</span><span class="p">[</span><span class="n">i</span><span \
class="p">]</span><span class="o">-></span><span class="n">bind</span><span \
class="p">();</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">103</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">glEnable</span><span class="p">(</span><span class="n">GL_BLEND</span><span \
class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">104</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">glBlendFunc</span><span class="p">(</span><span \
class="n">GL_DST_COLOR</span><span class="p">,</span> <span \
class="n">GL_ZERO</span><span class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">105</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">glPicture</span><span class="p">[</span><span class="n">i</span><span \
class="p">]</span><span class="o">-></span><span class="n">render</span><span \
class="p">(</span><span class="n">region</span><span class="p">,</span> <span \
class="o">*</span><span class="n">rectPicture</span><span class="p">[</span><span \
class="n">i</span><span class="p">]);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">106</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">glPicture</span><span class="p">[</span><span class="n">i</span><span \
class="p">]</span><span class="o">-></span><span class="n">unbind</span><span \
class="p">();</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">107</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">glPopAttrib</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please use \
glDisable(GL_BLEND) as the attribute stack is deprecated and causes problems for \
porting to OpenGL ES and OpenGL 3.
KWin source code will soon be changed to just push all attributes on initialization \
and pop all attributes on shutdown, so that they can easily be ifdefed.
And doing these state changes each time in the loop is rather inefficient ;-)</pre>
</div>
<br />
<p>- Martin</p>
<br />
<p>On September 1st, 2010, 2:48 p.m., Christoph Fritz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Christoph Fritz.</div>
<p style="color: grey;"><i>Updated 2010-09-01 14:48:42</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Inspired by roundedge http://www.nongnu.org/roundedge/ this kwin effect \
makes corners of the desktop rounded. Older Macs and Monitors had this feature \
too.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/CMakeLists.txt <span style="color: \
grey">(1170001)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/configs_builtins.cpp <span \
style="color: grey">(1170001)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/CMakeLists.txt \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>tags/KDE/4.5.1/kdebase/workspace/kwin/effects/roundedcorners/roundedcorners_config.ui \
<span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5225/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic