[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: Re: Review Request: add window shade state change to kwin effects,
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2010-07-23 18:40:40
Message-ID: 20100723184040.21941.8952 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-07-23 18:07:03, Thomas Lübking wrote:
> > a) Reacting on shade changes should not be necessary, since they'll trigger a \
> > resize. As the blur effect seems to support blank properties (ie. with an empty \
> > region), considering them to hint blurring the entire window, it should update \
> > the blur region in the resize case anyway - yesno? (maybe group them with the \
> > property notifications to not double the action in doubt)
> > b) as for a shading hints in general, imo some "aboutToToggleShade()" would be \
> > more helpful to allow shade effects (currently it's not possible to store the \
> > unshaded window and use it for an animation on "shade on" events) and it \
> > automatically indicates that the next resize will be due to a shade change
>
> Hugo Pereira Da Costa wrote:
> Hello Thomas
> I'm actually not sure it triggers a resize (otherwise the bug should not have been \
> here at the first place), or more precisely, right not it does not triggers \
> anything that results in a screen repaint for the blur pluggin, which is why even \
> if you "reset" the blur region (in the style, or inside the blur pluggin), the \
> screen is not updated immediately. At least, that was my conclusion from looking at \
> the code ...
> As for b) well ...
>
i'm quite sure it does, using it in BeDropped to "somehow" get a shade animation, the \
relevant Effect function would be ::windowGeometryShapeChanged(), providing the \
former geometry as well.
it might however be actually required to add a repaint for the old window region to \
ensure a visual update on the blur effect... (no idea why an explicit property change \
from the style wouldn't apply at all, though :-\
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4751/#review6691
-----------------------------------------------------------
On 2010-07-23 03:47:28, Hugo Pereira Da Costa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4751/
> -----------------------------------------------------------
>
> (Updated 2010-07-23 03:47:28)
>
>
> Review request for kwin and Martin Gräßlin.
>
>
> Summary
> -------
>
> This patch fixes the fact that the blurred area defined by the window is not \
> ignored (as it should) when a window gets shaded. I tried to address the issue in a \
> somewhat more generic way, since as far as I can tell there was no support for \
> shade state change in kwin effects so far. Meaning: 1/ added isShade() method to \
> EffectWindow (and its implementation), so that effects can test this 2/ added \
> windowShaded() and windowUnshaded() methods to the Effect class (and \
> implementation), similar to windowMinimized and windowUnminimized, so that effects \
> can re-implement, and trigger the relevant actions 3/ implemented windowShaded and \
> windowUnshaded in the blur effect pluggin, to trigger a blurRegion update, which \
> properly account for the isShade state
> Note: in principle, steps 1/ and 2/ would allow one to make an effect that e. g. \
> roll/unroll windows when shading (I think).
>
> This addresses bug 245388.
> https://bugs.kde.org/show_bug.cgi?id=245388
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/workspace/kwin/client.cpp 1153303
> /trunk/KDE/kdebase/workspace/kwin/effects.h 1153303
> /trunk/KDE/kdebase/workspace/kwin/effects.cpp 1153303
> /trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.h 1153303
> /trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp 1153303
> /trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h 1153303
> /trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.cpp 1153303
>
> Diff: http://reviewboard.kde.org/r/4751/diff
>
>
> Testing
> -------
>
> Tested using experimental oxygen-transparent branch, as well as bespin, with ARGB \
> and BlurBehind support.
>
> Thanks,
>
> Hugo
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4751/">http://reviewboard.kde.org/r/4751/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 23rd, 2010, 6:07 p.m., <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre>a) Reacting on shade changes should not be \
necessary, since they'll trigger a resize. As the blur effect seems to support \
blank properties (ie. with an empty region), considering them to hint blurring the \
entire window, it should update the blur region in the resize case anyway - yesno? \
(maybe group them with the property notifications to not double the action in doubt)
b) as for a shading hints in general, imo some "aboutToToggleShade()" would \
be more helpful to allow shade effects (currently it's not possible to store the \
unshaded window and use it for an animation on "shade on" events) and it \
automatically indicates that the next resize will be due to a shade change</pre> \
</blockquote>
<p>On July 23rd, 2010, 6:20 p.m., <b>Hugo Pereira Da Costa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre>Hello Thomas
I'm actually not sure it triggers a resize (otherwise the bug should not have \
been here at the first place), or more precisely, right not it does not triggers \
anything that results in a screen repaint for the blur pluggin, which is why even if \
you "reset" the blur region (in the style, or inside the blur pluggin), the \
screen is not updated immediately. At least, that was my conclusion from looking at \
the code ...
As for b) well ...
</pre>
</blockquote>
</blockquote>
<pre>i'm quite sure it does, using it in BeDropped to "somehow" get a \
shade animation, the relevant Effect function would be \
::windowGeometryShapeChanged(), providing the former geometry as well.
it might however be actually required to add a repaint for the old window region to \
ensure a visual update on the blur effect... (no idea why an explicit property change \
from the style wouldn't apply at all, though :-\</pre> <br />
<p>- Thomas</p>
<br />
<p>On July 23rd, 2010, 3:47 a.m., Hugo Pereira Da Costa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Martin Gräßlin.</div>
<div>By Hugo Pereira Da Costa.</div>
<p style="color: grey;"><i>Updated 2010-07-23 03:47:28</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">This patch fixes the fact that the blurred \
area defined by the window is not ignored (as it should) when a window gets shaded. I \
tried to address the issue in a somewhat more generic way, since as far as I can tell \
there was no support for shade state change in kwin effects so far. Meaning: 1/ added \
isShade() method to EffectWindow (and its implementation), so that effects can test \
this 2/ added windowShaded() and windowUnshaded() methods to the Effect class (and \
implementation), similar to windowMinimized and windowUnminimized, so that effects \
can re-implement, and trigger the relevant actions 3/ implemented windowShaded and \
windowUnshaded in the blur effect pluggin, to trigger a blurRegion update, which \
properly account for the isShade state
Note: in principle, steps 1/ and 2/ would allow one to make an effect that e. g. \
roll/unroll windows when shading (I think). </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">Tested using experimental oxygen-transparent \
branch, as well as bespin, with ARGB and BlurBehind support. </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=245388">245388</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/kwin/client.cpp <span style="color: \
grey">(1153303)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/effects.h <span style="color: \
grey">(1153303)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/effects.cpp <span style="color: \
grey">(1153303)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.h <span style="color: \
grey">(1153303)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp <span style="color: \
grey">(1153303)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h <span style="color: \
grey">(1153303)</span></li>
<li>/trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.cpp <span style="color: \
grey">(1153303)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4751/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic