--===============1712895858== Content-Type: multipart/alternative; boundary="===============5911373325191513786==" --===============5911373325191513786== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4332/ ----------------------------------------------------------- (Updated 2010-06-29 19:29:38.209000) Review request for kwin and Plasma. Changes ------- - Atom name updated - Plasma dashboard now sets own window class - KWin now detects dashboard by its window class (no more hacks) - removed magic number for blur effect, moved to kwineffects and changed in= blur effect, too - call reconfigure() in effect CTOR instead of duplicating code - implemented DTOR - brightness/saturation values are now handled as percentage - fixed blur region - removed german translation in .desktop files Summary ------- This patch adds a new KWin effect that allows to modify the appearance of t= he Plasma dashboard. It has a KCM configuration dialog where you can adjust= brightness, saturation and blur of the dashboard background. Blur depends = on the loaded blur plugin. I also patched the Plasma dashboard to recognize the loaded effect: If the = effect is loaded, the dashboard draws its background fully translucent. In = order for the Dashboard to recognize wether the effect is loaded, I added s= upport for the effect in Plasma::WindowEffects from kdelibs. The dashboard detection in the effect itself is hackish right now. As soon = as Plasma adds a proper class to the dashboard window, I will replace the h= ack with a class-check. This addresses bugs dashboard, detection and hackish. https://bugs.kde.org/show_bug.cgi?id=3Ddashboard https://bugs.kde.org/show_bug.cgi?id=3Ddetection https://bugs.kde.org/show_bug.cgi?id=3Dhackish Diffs (updated) ----- trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt 1144343 = trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp 1144343 = trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp 1144343 = trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt PRE-CRE= ATION = trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp PRE-CREA= TION = trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop PRE-= CREATION = trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h PRE-CREATI= ON = trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp P= RE-CREATION = trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.deskt= op PRE-CREATION = trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h PRE= -CREATION = trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui PR= E-CREATION = trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h 1144343 = trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp 114434= 3 = trunk/KDE/kdelibs/plasma/windoweffects.h 1144345 = trunk/KDE/kdelibs/plasma/windoweffects.cpp 1144345 = Diff: http://reviewboard.kde.org/r/4332/diff Testing ------- Code compiles, plugin loads, plugin configuration dialog is registered in K= CM Workspace module under "all effects". If the plugin is enabled, its sett= ings apply to the dashboard. Screenshots ----------- configuration dialog http://reviewboard.kde.org/r/4332/s/434/ dashboard with modified background http://reviewboard.kde.org/r/4332/s/435/ Thanks, Andreas --===============5911373325191513786== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde= .org/r/4332/

Review request for kwin and Plasma.
By Andreas Demmer.

Updated 2010-06-29 19:29:38.209000

Changes 
- Atom name updated
- Plasma dashboard now sets own window class
- KWin now detects dashboard by its window class (no more hacks)
- removed magic number for blur effect, moved to kwineffects and changed in=
 blur effect, too
- call reconfigure() in effect CTOR instead of duplicating code
- implemented DTOR
- brightness/saturation values are now handled as percentage
- fixed blur region
- removed german translation in .desktop files

Descripti= on 

This patch adds a new KWin effect =
that allows to modify the appearance of the Plasma dashboard. It has a KCM =
configuration dialog where you can adjust brightness, saturation and blur o=
f the dashboard background. Blur depends on the loaded blur plugin.

I also patched the Plasma dashboard to recognize the loaded effect: If the =
effect is loaded, the dashboard draws its background fully translucent. In =
order for the Dashboard to recognize wether the effect is loaded, I added s=
upport for the effect in Plasma::WindowEffects from kdelibs.

The dashboard detection in the effect itself is hackish right now. As soon =
as Plasma adds a proper class to the dashboard window, I will replace the h=
ack with a class-check.

Testing <= /h1> 
Code compiles, plugin loads, plugi=
n configuration dialog is registered in KCM Workspace module under "al=
l effects". If the plugin is enabled, its settings apply to the dashbo=
ard.
Bugs: dashboard= , = detection= , = hackish

Diffs= (updated)

  • trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt (1144343)
  • trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp (1144343)
  • trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp (1144343)
  • trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt (PRE-CREATION)
  • trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp (PRE-CREATION)
  • trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop <= span style=3D"color: grey">(PRE-CREATION)
  • trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h (PRE-CREATION)
  • trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cp= p (PRE-CREATION)
  • trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.de= sktop (PRE-CREATION)
  • trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h = (PRE-CREATION)
  • trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui= (PRE-CREATION)
  • trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h (1144343)
  • trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp (1144343)
  • trunk/KDE/kdelibs/plasma/windoweffects.h (= 1144345)
  • trunk/KDE/kdelibs/plasma/windoweffects.cpp (1144345)

View Diff

Screensho= ts

--===============5911373325191513786==-- --===============1712895858== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kwin mailing list kwin@kde.org https://mail.kde.org/mailman/listinfo/kwin --===============1712895858==--