[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Review Request: new KWin effect: Dashboard
From:       "Andreas Demmer" <ademmer () opensuse ! org>
Date:       2010-06-15 20:31:15
Message-ID: 20100615203115.20294.87318 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4332/
-----------------------------------------------------------

Review request for kwin and Plasma.


Summary
-------

This patch adds a new KWin effect that allows to modify the appearance of the Plasma \
dashboard. It has a KCM configuration dialog where you can adjust brightness, \
saturation and blur of the dashboard background. Blur depends on the loaded blur \
plugin.

I also patched the Plasma dashboard to recognize the loaded effect: If the effect is \
loaded, the dashboard draws its background fully translucent. In order for the \
Dashboard to recognize wether the effect is loaded, I added support for the effect in \
Plasma::WindowEffects from kdelibs.

The dashboard detection in the effect itself is hackish right now. As soon as Plasma \
adds a proper class to the dashboard window, I will replace the hack with a \
class-check.


This addresses bugs dashboard, detection and hackish.
    https://bugs.kde.org/show_bug.cgi?id=dashboard
    https://bugs.kde.org/show_bug.cgi?id=detection
    https://bugs.kde.org/show_bug.cgi?id=hackish


Diffs
-----

  trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt 1138357 
  trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp 1138357 
  trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt PRE-CREATION 
  trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h PRE-CREATION 
  trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp PRE-CREATION 
  trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop PRE-CREATION 
  trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.desktop \
PRE-CREATION   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h \
PRE-CREATION   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp \
PRE-CREATION   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui \
PRE-CREATION   trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboardeffectconfig.ui \
PRE-CREATION   trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp \
1138357   trunk/KDE/kdelibs/plasma/windoweffects.h 1138355 
  trunk/KDE/kdelibs/plasma/windoweffects.cpp 1138355 

Diff: http://reviewboard.kde.org/r/4332/diff


Testing
-------

Code compiles, plugin loads, plugin configuration dialog is registered in KCM \
Workspace module under "all effects". If the plugin is enabled, its settings apply to \
the dashboard.


Screenshots
-----------

configuration dialog
  http://reviewboard.kde.org/r/4332/s/434/
dashboard with modified background
  http://reviewboard.kde.org/r/4332/s/435/


Thanks,

Andreas

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin


[prev in list] [next in list] [prev in thread] [next in thread]