[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: BUMP Re: Window resizing
From:       Martin =?iso-8859-15?q?Gr=E4=DFlin?= <kde () martin-graesslin ! com>
Date:       2010-04-25 8:54:28
Message-ID: 201004251054.37499.kde () martin-graesslin ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Am Samstag 24 April 2010 19:52:31 schrieb Thomas Lübking:
> Hi, attached is (again) the kwin core part of a patch for resizing effects
> (i.e. only provides support on the infrastructure, no effect itself)
> 
> Due to the softfreeze i thought to bring it up again in the last minute :\
> 
> Comments?
Yes, do you have the modifications to resize effect around? IIRC the effect 
still only has the outline mode but not the texture scaling. If you send it to 
the list till evening I will commit, otherwise put it on the feature plan ;-)
> (I.e. can anyone push it  - or i dump a _clean_ kwin trunk, apply and push
> myself ;-)
> Do we need to add (or modify) the effect before the softfreeze (strings?)
Only thing I can think of is adding a configuration option to show the 
outline. I just checked the schedule and soft message freeze is on May 19th - 
so enough time to add strings.
> 
> Cheers,
> Thomas
> 
> Am Monday 21 December 2009 schrieb Martin Gräßlin:
> > Given that we are post beta 2 I think it's not a good idea to change the
> > 
> >  effect from outline to texture scale ;-)
> 
> No problem, having the general architecture, m/we could also ship it as
> external plugin meanwhile... ;-)
> 
> >  But I think we should do that for
> >  4.5 and even go a step further: if compositing is enabled and the resize
> >  effect is enabled the settings are ignored and the "transparent resize"
> >  is used with texture scale in the effect.
> 
> This is the current behaviour (as i saw few point in using a resize effect
> on top of a "real" resize)
> 
> > Now to the part about dropping the rubberband: that part I would like to
> > 
> >  see also in 4.4 as it removes a nasty visual glitch. But I have some
> >  comments to the code ;-)
> 
> Stripped down patch attached. (Notice that activating the resize effect
> will by this implementation immediately switch to a transparent resize
> mode)
> 
> > * First of all: coding style does not match everywhere :-)
> 
> Bwuahahahhaaaaaaa...
> *sniff*... i tried so hard :'-(
> KWins code style still drives me nuts ;-)
> 
> I (think) i fixed bracket margins (i think i had indention right anyway)
> but i'm really unsure about (esp. trailing) bracket padding (seems a bit
> inconsistent to me ;-P
> 
> > * Effect::provideResizeEffect() should return false in the base
> 
> [...]
> 
> > EffectsHandler
> 
> stripped patch attached (i just stayed with the present recursion model)
> the existing resize effect remains untouched (except now being a resize
> effect)
> 
> > * version number of kwineffects has to be increased as it is a ABI change
> 
> done
> 
> Cheers

["signature.asc" (application/pgp-signature)]

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin


[prev in list] [next in list] [prev in thread] [next in thread]