From kwin  Mon Aug 31 11:21:51 2009
From: Martin =?iso-8859-15?q?Gr=E4=DFlin?= <kde () martin-graesslin ! com>
Date: Mon, 31 Aug 2009 11:21:51 +0000
To: kwin
Subject: Re: Drop kwin's fullscreen hack
Message-Id: <200908311322.09464.kde () martin-graesslin ! com>
X-MARC-Message: https://marc.info/?l=kwin&m=125171776114602
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============0408433723=="

--===============0408433723==
Content-Type: multipart/signed;
  boundary="nextPart2241008.nWQ3QJTU1c";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart2241008.nWQ3QJTU1c
Content-Type: multipart/mixed;
  boundary="Boundary-01=_QJ7mKge14HD6Txi"
Content-Transfer-Encoding: 7bit


--Boundary-01=_QJ7mKge14HD6Txi
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Am Montag 31 August 2009 10:50:28 schrieb Martin Gr=E4=DFlin:
> Am Montag 31 August 2009 01:37:02 schrieb Thomas L=FCbking:
> > Am Monday 31 August 2009 schrieb Christoph Feck:
> > > Then I have misunderstood the request. It states "Attached is a patch
> > > to remove kwin's fullscreen hack for not-netwm windows [...]", so it
> > > should not have any effect on netwm windows?
> >
> > No. NETWM windows hint their fullscreen mode with a flag, but when there
> > was no NETWM, windows were just fullscreen by preventing a window border
> > an moveResize to the screen area.
> >
> > IMHO the fullscreen hack should meanwhile be irrelevant, but:
> > 1) it should not be unconditionally necessary to remove it for the MID
> > shell (see my last mail)
> > 2) instead of removing i'd just blind it (keep the code and add a GUIle=
ss
> > option) - you really /never/ know who uses what ten year old app that
> > might suddenly stumble on this.
> >
> > If we don't get some harsh bug reports, we can still completely drop it
> > for 4.4.1 or 4.5...
>
> agreed - I prepare a new patch which keeps the hack and makes it optional
> and disabled by default.
here's the new patch. Unfortunately I couldn't really test it as I don't kn=
ow=20
of any application which is that broken ;-)

--Boundary-01=_QJ7mKge14HD6Txi
Content-Type: text/x-patch;
  charset="UTF-8";
  name="fullscreen-hack-legacy.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
	filename="fullscreen-hack-legacy.diff"

commit d9bea8cf76b546895551ab95d5074194cf8c94df
Author: Martin Gr=C3=A4=C3=9Flin <ubuntu@martin-graesslin.com>
Date:   Mon Aug 31 13:19:14 2009 +0200

    Option to disable the legacy fullscreen hack

diff --git a/geometry.cpp b/geometry.cpp
index c4cc4f2..712bab1 100644
=2D-- a/geometry.cpp
+++ b/geometry.cpp
@@ -2538,6 +2538,8 @@ QRect Client::fullscreenMonitorsArea(NETFullscreenMon=
itors requestedTopology) co
=20
 int Client::checkFullScreenHack( const QRect& geom ) const
     {
+    if( !options->legacyFullscreenSupport )
+        return 0;
     // if it's noborder window, and has size of one screen or the whole de=
sktop geometry, it's fullscreen hack
     if( noBorder() && app_noborder && isFullScreenable( true ))
         {
diff --git a/options.cpp b/options.cpp
index 946b91e..2ba084c 100644
=2D-- a/options.cpp
+++ b/options.cpp
@@ -87,6 +87,8 @@ unsigned long Options::updateSettings()
=20
     rollOverDesktops =3D config.readEntry("RollOverDesktops", true);
=20
+    legacyFullscreenSupport =3D config.readEntry( "LegacyFullscreenSupport=
", false );
+
 //    focusStealingPreventionLevel =3D config.readEntry( "FocusStealingPre=
ventionLevel", 2 );
     // TODO use low level for now
     focusStealingPreventionLevel =3D config.readEntry( "FocusStealingPreve=
ntionLevel", 1 );
diff --git a/options.h b/options.h
index 6f72785..e9a4551 100644
=2D-- a/options.h
+++ b/options.h
@@ -207,6 +207,11 @@ class Options : public KDecorationOptions
          */
         QStringList ignorePositionClasses;
=20
+        /**
+        * support legacy fullscreen windows hack: borderless non-netwm win=
dows with screen geometry
+        */
+        bool legacyFullscreenSupport;
+
         bool checkIgnoreFocusStealing( const Client* c );
=20
         WindowOperation operationTitlebarDblClick() { return OpTitlebarDbl=
Click; }

--Boundary-01=_QJ7mKge14HD6Txi--

--nextPart2241008.nWQ3QJTU1c
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iJwEAAECAAYFAkqbslAACgkQ/umpWjNT6CI6KgP9G/YqJ+kU9lEbvpaU4Jg88Ly3
Z7dKWGLmjIVbmcWS1Bh5FA3vO0cdhz5r8yb+hFBaW5QUYa+rBdm6xVqu7VRNshzi
Em5Y/RSNImV1Q606KPv7w8vF4kk+BKJO9zlgWqV24WywK3ag7p6kOyCk9Uf6TJ6h
UrldVxPiuSfxK5LBACI=
=XNb0
-----END PGP SIGNATURE-----

--nextPart2241008.nWQ3QJTU1c--

--===============0408433723==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin

--===============0408433723==--