[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: KDecoration vs KDecorationFactory
From:       "Lucas Murray" <lmurray () undefinedfire ! com>
Date:       2009-01-14 5:43:27
Message-ID: f09827650901132143p536b9ccap937f51930b0dc192 () mail ! gmail ! com
[Download RAW message or body]

On Wed, Jan 14, 2009 at 2:25 PM, Aaron J. Seigo <aseigo@kde.org> wrote:
> On Tuesday 13 January 2009, Lucas Murray wrote:
>> > i will continue to work on the correctness patch for 4.3, but i fear it
>> > is becoming too invasive to go into 4.2.0 at this time with a comfortable
>> > level of safety. the patch sent earlier works as well as it can given the
>> > infrastructure in kwin at that time.
>>
>> What you are writing this for is not a blocker so it should not be
>> added to 4.2 at all, you missed the deadline and even if you are a/the
>> high-ranking KDE developer there should be NO exception. Pushing a
>> completely new (And minor) feature during RC 1 that requires changes
>> to a large amount of code is just stupid.
>
> *sigh*
>
> ok. so unless i'm very much mistaken i said in this email that the new patch
> is going to require too much change and should not be considered for 4.2.
>
> with me so far?
>
> ok.
>
> next i suggested that the patch that actually works as-is and improves the
> user experience goes into 4.2 so as to honour the art direction, and we can
> get the technical correctness nailed in 4.3.
>
> i also noted that i'm willing to continue on and help with that technical
> correctness for 4.3.
>
> it has nothing to do with my "rank", and everything to do with the user.
>
> p-r-i-o-r-i-t-i-e-s.

Fine, do it, I don't care. The other patch breaks under certain
conditions but as you mentioned it's only under very specific
conditions. I never use the stripes myself so I forgot what the
defaults actually were, adding the patch makes the default what I
personally use so I guess that's fine.

I just want to mention that I do not like the way this patch was
proposed, it should not have been this late in the development cycle.
The next time you do this please do it BEFORE RC 1 okay? Thanks in
advance.
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]