[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: clientArea crash
From:       "Lucas Murray" <lmurray () undefinedfire ! com>
Date:       2008-11-19 3:55:03
Message-ID: f09827650811181955t4105ad81vaf4c8e46238c7500 () mail ! gmail ! com
[Download RAW message or body]

On Tue, Nov 18, 2008 at 4:40 AM, Guillaume Pothier <gpothier@gmail.com> wrote:
> Hi, I'm starting to chase down the famous bug #173017, where kwin
> crashes in Workspace::clientArea. In the scenario I'm currently
> investigating, the screen argument is -1, which is checked and
> replaced by activeScreen() (around geometry.cpp:232). However,
> activeScreen() also returns -1, hence the crash. The reason
> activeScreen() returns -1 is that the active_screen field is -1, and
> it is set to -1 in Workspace::takeActivity() (around
> activation.cpp:375). And this happens because a client has -1 as its
> screen. Is that a legal value for a client to have? What should be
> checked here?

The active screen should never be -1 as it just doesn't make sense. It
should remain whatever the old active screen was if == -1 and if the
value is still out of range (For example the screen was removed) it
should default to 0 or the nearest if you can work it out, but I don't
think it's worth it.
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]